Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/registry: Remove support for DeprecatedBeacon #4593

Closed
wants to merge 1 commit into from

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Mar 23, 2022

The PVSS backend is no longer present in 22.x and so the field is now
removed, and even genesis registrations without a VRF signing key will
be rejected.

Fixes #4394
Fixes #4393

@Yawning Yawning enabled auto-merge March 23, 2022 08:02
@Yawning Yawning force-pushed the yawning/cleanup/pvss-remnants branch from f931225 to 2f15dc3 Compare March 23, 2022 08:03
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is consensus breaking as if someone does include the field, some nodes will accept it while others would reject it. I would rather avoid consensus breaking changes at this time.

The PVSS backend is no longer present in 22.x and so the field is now
removed, and even genesis registrations without a VRF signing key will
be rejected.
@Yawning Yawning force-pushed the yawning/cleanup/pvss-remnants branch from 2f15dc3 to 363c084 Compare March 23, 2022 08:33
@Yawning Yawning disabled auto-merge March 23, 2022 08:34
@Yawning Yawning marked this pull request as draft March 28, 2022 12:51
@Yawning
Copy link
Contributor Author

Yawning commented Apr 14, 2022

Superseded by #4668

@Yawning Yawning closed this Apr 14, 2022
@Yawning Yawning deleted the yawning/cleanup/pvss-remnants branch April 14, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants