-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/oasis-node/cmd: Add oasis-node stake account nonce CLI command #3559
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3559 +/- ##
==========================================
- Coverage 66.56% 66.46% -0.10%
==========================================
Files 377 377
Lines 34273 34288 +15
==========================================
- Hits 22813 22791 -22
- Misses 8183 8189 +6
- Partials 3277 3308 +31
Continue to review full report at Codecov.
|
Add getAccountNonce() helper to stakeCLIImpl and use it obtain the accounts' nonces instead of hardcoding them.
@@ -0,0 +1,3 @@ | |||
go/oasis-node/cmd: Add `oasis-node stake account nonce` CLI command | |||
|
|||
It can be used to get a staking account's current nonce. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering what's the use case for this, since the stake account info
command already includes this in response?
The only thing i can come up with is using this in some automation - which i think we actually want to discourage and instead defer to the grpc api.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering what's the use case for this, since the
stake account info
command already includes this in response?
The use case I have in mind is to have an elegant way of getting an account's nonce instead of having to parse the stake account info
command's response which is not guaranteed to stay stable.
The only thing i can come up with is using this in some automation - which i think we actually want to discourage and instead defer to the grpc api.
You guessed it 🙂. I've had some occasions where it was the most convenient to just write a simple Bash script to generate, sign and submit a batch of staking transactions.
Something like a more proper Go program acting as a gRPC client and a CLI would be nice, but out of scope for these smallish projects.
So, I would say that we probably don't want to discourage all such usage of our CLI tools, just not relying on their output being stable and using them to actually write a backend, e.g. a gateway, a staking dashboard, ...
It can be used to get a staking account's current nonce.