Allow runtimes to have a custom dispatcher #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberci
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2749 +/- ##
==========================================
- Coverage 62.74% 62.29% -0.45%
==========================================
Files 384 384
Lines 36258 36258
==========================================
- Hits 22749 22588 -161
- Misses 10616 10815 +199
+ Partials 2893 2855 -38
Continue to review full report at Codecov.
|
jberci
force-pushed
the
jberci/feature/dispatcher
branch
from
3cc6176 to
5f03879
Compare
pro-wh
approved these changes
Mar 2, 2020
runtime/src/dispatcher.rs
Outdated
| { | ||
| txn | ||
| } else { | ||
| Box::new(TxnMethDispatcher::new()) |
There was a problem hiding this comment.
what if we made the initializer do this internally
There was a problem hiding this comment.
Not sure we can... whoever constructs a concrete dispatcher will need its specific interface, so it would be problematic if the initializer itself returned the general boxed trait already.
There was a problem hiding this comment.
ok what about yet another implementation that's specifically a no-op dispatcher
jberci
force-pushed
the
jberci/feature/dispatcher
branch
from
5f03879 to
d658954
Compare
jberci
force-pushed
the
jberci/feature/dispatcher
branch
from
d658954 to
9d347a7
Compare
jberci
force-pushed
the
jberci/feature/dispatcher
branch
from
9d347a7 to
cdb2e53
Compare
Yawning
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2281.