go/worker/beacon: Don't submit VRF proofs if registration disabled

.changelog/4536.bugfix.md

@@ -0,0 +1 @@
+go/worker/beacon: Don't submit VRF proofs if registration disabled

go/oasis-node/cmd/node/node.go

@@ -338,6 +338,7 @@ func (n *Node) initRuntimeWorkers() error {
 		n.Identity,
 		n.Consensus,
 		n.commonStore,
+		n.RegistrationWorker,
 	)
 	if err != nil {
 		return err

go/worker/beacon/worker.go

@@ -10,6 +10,7 @@ import (
 	"github.com/oasisprotocol/oasis-core/go/common/logging"
 	"github.com/oasisprotocol/oasis-core/go/common/persistent"
 	consensus "github.com/oasisprotocol/oasis-core/go/consensus/api"
+	"github.com/oasisprotocol/oasis-core/go/worker/registration"
 )
 
 const workerName = "worker/beacon"
@@ -61,6 +62,7 @@ func New(
 	identity *identity.Identity,
 	consensus consensus.Backend,
 	store *persistent.CommonStore,
+	registrationWorker *registration.Worker,
 ) (*Worker, error) {
 	var (
 		err     error
@@ -74,6 +76,12 @@ func New(
 	}
 
 	initLogger := logging.GetLogger(workerName)
+	if registrationWorker.WillNeverRegister() {
+		// Some node configurations never register, and that's ok.
+		initLogger.Info("registration worker disabled, also disabling beacon worker")
+		close(w.allQuitCh)
+		return nil, nil
+	}
 
 	if w.vrf, err = newVRF(w); err == nil {
 		w.allQuitWg.Add(1)

go/worker/registration/worker.go

@@ -918,6 +918,11 @@ func (w *Worker) RequestDeregistration() error {
 	return nil
 }
 
+// WillNeverRegister returns true iff the worker will never register.
+func (w *Worker) WillNeverRegister() bool {
+	return !w.entityID.IsValid() || w.registrationSigner == nil
+}
+
 // GetRegistrationSigner loads the signing credentials as configured by this package's flags.
 func GetRegistrationSigner(logger *logging.Logger, dataDir string, identity *identity.Identity) (signature.PublicKey, signature.Signer, error) {
 	var defaultPk signature.PublicKey
@@ -1041,7 +1046,7 @@ func (w *Worker) Start() error {
 	w.logger.Info("starting node registration service")
 
 	// HACK: This can be ok in certain configurations.
-	if !w.entityID.IsValid() || w.registrationSigner == nil {
+	if w.WillNeverRegister() {
 		w.logger.Warn("no entity/signer for this node, registration will NEVER succeed")
 		// Make sure the node is stopped on quit and that it can still respond to
 		// shutdown requests from the control api.