Skip to content

Commit

Permalink
now mark judge later to a rating!
Browse files Browse the repository at this point in the history
  • Loading branch information
epugh committed Dec 8, 2023
1 parent 350b37f commit 1ed1b89
Show file tree
Hide file tree
Showing 3 changed files with 43 additions and 7 deletions.
27 changes: 22 additions & 5 deletions app/controllers/books_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@
class BooksController < ApplicationController
before_action :find_book,
only: [ :show, :edit, :update, :destroy, :combine, :assign_anonymous, :delete_ratings_by_assignee,
:reset_unrateable, :reset_judge_later, :delete_query_doc_pairs_below_position ]
:reset_unrateable, :reset_judge_later, :delete_query_doc_pairs_below_position,
:eric_steered_us_wrong ]
before_action :check_book,
only: [ :show, :edit, :update, :destroy, :combine, :assign_anonymous, :delete_ratings_by_assignee,
:reset_unrateable, :reset_judge_later, :delete_query_doc_pairs_below_position ]
:reset_unrateable, :reset_judge_later, :delete_query_doc_pairs_below_position,
:eric_steered_us_wrong ]

before_action :find_user, only: [ :reset_unrateable, :reset_judge_later, :delete_ratings_by_assignee ]

Expand Down Expand Up @@ -196,14 +198,29 @@ def reset_judge_later
end

def delete_query_doc_pairs_below_position
threshold = params[:threshold]
query_doc_pairs_to_delete = @book.query_doc_pairs.where('position > ?', threshold)
position = params[:position]
query_doc_pairs_to_delete = @book.query_doc_pairs.where('position > ?', position)
query_doc_pairs_count = query_doc_pairs_to_delete.count
query_doc_pairs_to_delete.destroy_all

UpdateCaseJob.perform_later @book
redirect_to book_path(@book),
:notice => "Deleted #{query_doc_pairs_count} query/doc pairs below position #{threshold}."
:notice => "Deleted #{query_doc_pairs_count} query/doc pairs below position #{position}."
end

def eric_steered_us_wrong
rating = params[:rating]
judgements_to_update = @book.judgements.where(judge_later: true)
judgements_to_update_count = judgements_to_update.count
judgements_to_update.each do |judgement|
judgement.judge_later = false
judgement.rating = rating
judgement.save
end

UpdateCaseJob.perform_later @book
redirect_to book_path(@book),
:notice => "Mapped #{judgements_to_update_count} judgements to have rating #{rating}."
end

private
Expand Down
21 changes: 19 additions & 2 deletions app/views/books/edit.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@
</p>
<%= form_for(@book, url: delete_query_doc_pairs_below_position_book_path(@book), method: :delete, data: { confirm: "Are you sure?" }) do |form| %>
<div class="mb-3">
<%= form.label :threshold, class: 'form-label' %>
<%= select_tag "threshold", options_for_select(@book.query_doc_pairs.distinct.pluck(:position)), required: true, prompt: "Please select threshold to delete below", class: 'form-control' %>
<%= form.label :position, class: 'form-label' %>
<%= select_tag "position", options_for_select(@book.query_doc_pairs.distinct.pluck(:position).sort), required: true, prompt: "Please select threshold to delete below", class: 'form-control' %>
</div>
<p>
<div class="actions">
Expand All @@ -115,6 +115,23 @@
</p>
<% end %>

<h3>Assign Rating to Judge Later Judgements</h3>

<p class="form-text">
Currently it can be easier to skip judgements that you know are good (or bad) using the Judge Later option, and then come back and give them a rating.
</p>
<%= form_for(@book, url: eric_steered_us_wrong(@book), method: :patch, data: { confirm: "Are you sure?" }) do |form| %>
<div class="mb-3">
<%= form.label :rating, class: 'form-label' %>
<%= select_tag "rating", options_for_select(@book.scorer.scale.sort), required: true, prompt: "Please select rating to assign", class: 'form-control' %>
</div>
<p>
<div class="actions">
<%= form.submit 'Assign Rating and Clear Judge Later' %>
</div>
</p>
<% end %>

<br>

<%= button_to 'Cancel', @book, method: :get %>
Expand Down
2 changes: 2 additions & 0 deletions config/routes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@
delete 'reset_judge_later/:user_id', action: :reset_judge_later, as: :reset_judge_later
delete 'delete_query_doc_pairs_below_position', action: :delete_query_doc_pairs_below_position,
as: :delete_query_doc_pairs_below_position
patch 'eric_steered_us_wrong',
action: :eric_steered_us_wrong, as: :eric_steered_us_wrong
end
end

Expand Down

0 comments on commit 1ed1b89

Please sign in to comment.