Move segment/synapse cleanup out of Connections (Python) #3654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is essentially algorithm code, not data structure code, so it shouldn't happen automagically in the Connections. This finally fixes the bug in synapse cleanup -- we were destroying them one at a time rather than as batches. So there was a risk that we could keep destroying and recreating the same synapse.
Add proper support for serializing numActivePotentialSynapsesForSegment and lastUsedIterationForSegment.
This requires updating other dependencies. A couple tests fail with the new numpy version, so I fixed those tests.
|
Once merged, I will release NuPIC 0.7.0. @numenta/nupic-committers |
rhyolight
reviewed
Jun 2, 2017
| """ @param numCells (int) Number of cells in collection """ | ||
|
|
||
| # Save member variables | ||
| self.numCells = numCells | ||
| assert maxSegmentsPerCell > 0 | ||
| assert maxSynapsesPerSegment > 0 | ||
| self.maxSegmentsPerCell = maxSegmentsPerCell |
There was a problem hiding this comment.
Thank you I hate seeing assert outside test code.
|
@scottpurdy this is conceptually the same change as numenta/nupic.core-legacy#1327, so you might be the best person to review it. |
scottpurdy
approved these changes
Jun 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3653
This is the Python counterpart to numenta/nupic.core-legacy#1327
The checks will fail. I need to do a nupic.core release.