Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider hiding fields in Event #310

Open
erickt opened this issue May 10, 2021 · 1 comment
Open

Consider hiding fields in Event #310

erickt opened this issue May 10, 2021 · 1 comment

Comments

@erickt
Copy link
Contributor

erickt commented May 10, 2021

As part of developing #307, I realized it might be worth hiding the public fields in Event as part of 5.0.0. This would allow the underlying object to be extended with new attributes without breaking existing clients. I have a proof-of-concept of this change in https://github.com/erickt/notify/tree/hide-fields that's built upon #307 that I can push up after we address #306.

@0xpr03
Copy link
Member

0xpr03 commented May 11, 2021

I've got no real stakes in this, we've had no problems with them being public so far. Also your current implementation adds an additional .clone - though its probably irrelevant. So I'm ok with merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants