chore: unconstrained improvements #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guipublic
commented
Feb 4, 2025
| @@ -169,14 +169,12 @@ unconstrained fn build_msg_block<let N: u32>( | |||
| let mut msg_block: MSG_BLOCK = [0; INT_BLOCK_SIZE]; | |||
|
|
|||
| // We insert `BLOCK_SIZE` bytes (or up to the end of the message) | |||
| let block_input = if msg_start + BLOCK_SIZE > message_size { | |||
There was a problem hiding this comment.
this does not change the code size, but I believe it is a be nicer to read
guipublic
commented
Feb 4, 2025
src/sha256.nr
Outdated
| for j in 0..INT_SIZE { | ||
| let k = i * INT_SIZE + j; | ||
| let msg_byte = if k < block_input { |
There was a problem hiding this comment.
unless I am mistaken, k is always less than block_input?
There was a problem hiding this comment.
oh no it is not, I missed the int_input increment, so I restored the previous version.
We could try to peel the last iteration though, but it'll increase the bytecode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
A few improvements over #9
Summary*
I did not have time to review #9 until it was merged, so I put my suggested changes as a PR.
Additional Context
PR Checklist*
cargo fmton default settings.