Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(nargo): add integration test for "hello world" flow #1038

Merged
merged 3 commits into from
Mar 27, 2023
Merged

chore(nargo): add integration test for "hello world" flow #1038

merged 3 commits into from
Mar 27, 2023

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Mar 25, 2023 •
edited
Loading

Related issue(s)

Related to why #1029 wasn't caught before nightly release

Description

Summary of changes

I've added an integration test which tests that, using the built binary, it is possible to complete the steps listed at https://noir-lang.org/getting_started/hello_world.html

Dependency additions / changes

Test additions / changes

Integration test added for performing the "hello world" example from the book.

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@TomAFrench TomAFrench requested a review from phated March 27, 2023 18:20
phated
phated previously approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming my github edit passes rust CI, this looks good to me.

@TomAFrench TomAFrench requested a review from phated March 27, 2023 18:53
@TomAFrench TomAFrench enabled auto-merge March 27, 2023 18:57
@TomAFrench TomAFrench added this pull request to the merge queue Mar 27, 2023
Merged via the queue into master with commit 5fa0f57 Mar 27, 2023
@TomAFrench TomAFrench deleted the hello_world_integration_test branch March 27, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @phated