feat: Add support for remaining black box opcodes using barretenberg
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds Pedersen, Schnorr and ScalarMul opcodes - adds new flake based nix build method - build can be done with `nix build` or independently from nix with `build.sh` and associated scripts - adds custom noir test packages on which tests are based
TomAFrench
changed the title
barretenberg
- build is invoked through nix flake `nix build .#` - tests brought to single file so we're building once, invoking tests for browser and nodejs in one place - removes unnecessary node/yarn setup as these are provided with runner
This was referenced Jun 7, 2023
* master: feat: added public_witness wasm utils (#22)
TomAFrench
reviewed
Jun 8, 2023
TomAFrench
force-pushed
the
kh-missing-opcodes
branch
from
7e05ddf to
2db368a
Compare
Closed
kobyhallx
added a commit
to noir-lang/acvm
that referenced
this pull request
Jul 26, 2023
noir-lang/acvm-simulator#26) Co-authored-by: jonybur <[email protected]> Co-authored-by: TomAFrench <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds missing OpCodes with barretenberg library
Summary of changes
nix buildor independently from nix withbuild.shand associated scripts (includes changes coauthored by @jonybur (wip) nix flake #19)Dependency additions / changes
Test additions / changes
Browser tests expanded to match nodejs test suit.
Checklist
cargo fmtwith default settings.Documentation needs
Additional context