Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: lazily load modules on test runner #56980

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Feb 9, 2025

Small refactor to lazy load as much as possible. Most tests doesn't even use all of these... Also, try to destruct the require on the declaration to see which functionality we are using from the required module.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 9, 2025
@anonrig anonrig force-pushed the yagiz/improve-testing branch from a099ba0 to 86222db Compare February 9, 2025 19:19
test/common/udp.js Show resolved Hide resolved
test/common/v8.js Show resolved Hide resolved
@anonrig anonrig requested review from targos and jasnell February 9, 2025 19:28
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 9, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 9, 2025
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.15%. Comparing base (a2aa6ca) to head (86222db).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #56980   +/-   ##
=======================================
  Coverage   89.14%   89.15%           
=======================================
  Files         665      665           
  Lines      193179   193179           
  Branches    37197    37198    +1     
=======================================
+ Hits       172213   172224   +11     
+ Misses      13728    13727    -1     
+ Partials     7238     7228   -10     

see 24 files with indirect coverage changes

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants