docs: update options in filehandle.appendFile() #56972
Open
+20
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
reviewed
Feb 9, 2025
lpinca
approved these changes
Feb 10, 2025
| await assert.rejects(fileHandle.appendFile(buffer, { signal }), { | ||
| name: 'AbortError' | ||
| }); | ||
| } finally { |
There was a problem hiding this comment.
The try...catch is not needed as the process exits when an error occurs.
| validateAppendBuffer(), | ||
| validateAppendString(), | ||
| doAppendAndCancel(), | ||
| ]).then(common.mustCall()); |
There was a problem hiding this comment.
Suggested change
| ]).then(common.mustCall()); | |
| ]); |
This is no longer needed. By default, an unhandled promise rejection makes the process exit with a non-zero exit code.
|
Please replace |
y-hsgw
force-pushed
the
docs/fs-file-handle-append-file
branch
from
d40ef79 to
47fb2d6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56972 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 665 665
Lines 193165 193174 +9
Branches 37191 37193 +2
=======================================
+ Hits 172181 172193 +12
- Misses 13729 13740 +11
+ Partials 7255 7241 -14 |
|
Can you please rebase and foce push to keep only two commits? Thank you. |
y-hsgw
force-pushed
the
docs/fs-file-handle-append-file
branch
from
78c5b07 to
42595e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the documentation for the
filehandle.appendFile()options.And I also added related tests.