Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 13.3.415.20 #56959

Closed
wants to merge 23 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
c7f674d
deps: update V8 to 13.3.415.20
targos Feb 7, 2025
f5987ab
build: reset embedder string to "-node.0"
targos Feb 7, 2025
cf32db3
src: update NODE_MODULE_VERSION to 135
targos Feb 7, 2025
5bb479d
deps: always define V8_EXPORT_PRIVATE as no-op
targos Sep 21, 2022
2aef73a
deps: disable V8 concurrent sparkplug compilation
targos Apr 6, 2023
33d5f38
deps: patch V8 to avoid duplicated zlib symbol
targos Sep 16, 2023
491a5b2
deps: patch V8 to support compilation with MSVC
StefanStojanovic Apr 21, 2024
d2774c2
deps: fix FP16 bitcasts.h
StefanStojanovic May 28, 2024
ee32ce1
deps: always define V8_NODISCARD as no-op
targos Aug 8, 2024
1e48040
deps: define V8_PRESERVE_MOST as no-op on Windows
StefanStojanovic Dec 16, 2024
b3eaf29
build: remove support for s390 32-bit
richardlau Sep 18, 2024
7fc4386
build: enable shared RO heap with ptr compression
targos Sep 21, 2024
81883b0
tools: update V8 gypfiles for 13.1
targos Sep 25, 2024
2ef20c6
tools: update V8 gypfiles for 13.2
targos Oct 28, 2024
2df68dd
build,src,tools: adapt build config for V8 13.3
targos Dec 19, 2024
b3ca191
build: add `/bigobj` to compile V8 on Windows
targos Feb 5, 2025
1c85fc7
src: replace uses of FastApiTypedArray
targos Feb 8, 2025
c68131c
Revert "test: disable fast API call count checks"
targos Jan 31, 2025
dec5890
test: update test-linux-perf-logger
targos Feb 4, 2025
a4064bf
test: adapt assert tests to stack trace changes
targos Dec 20, 2024
fa3d23b
src: lock the isolate properly in IsolateData destructor
joyeecheung Feb 13, 2025
a1ecc28
test: use v8::Locker to lock isolates properly in cctest
joyeecheung Feb 13, 2025
ebe4dca
deps: fix v8::String namespace
joyeecheung Feb 14, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: lock the isolate properly in IsolateData destructor
Otherwise it may fail the DCHECK that uses the locked thread
as a fast path to get the current thread.
  • Loading branch information
joyeecheung committed Feb 13, 2025
commit fa3d23b26b8d5e08505c77262337b8e3313845d5
1 change: 1 addition & 0 deletions src/env.cc
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,7 @@ IsolateData::IsolateData(Isolate* isolate,

IsolateData::~IsolateData() {
if (cpp_heap_ != nullptr) {
v8::Locker locker(isolate_);
// The CppHeap must be detached before being terminated.
isolate_->DetachCppHeap();
cpp_heap_->Terminate();
Expand Down
Loading