AppVeyor: Test and support versions 8, 10, 12, 14, 16, 17, 18, 19, 20, 21, and 22 #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
changed the title
|
Thank you. This looks good to me. While I do not think testing on multiple Python versions for the sake of testing Python is necessary, I do not see it hurting apart from longer runtimes. The reason for originally specifying multiple Python versions was just to get it all working with various images and versions. |
The real problem is
Please review and merge #985 and make a new npm release. If long test runtimes (2+ hours) is an issue then please review and merge
|
This was referenced Feb 13, 2025
Python 3.9 is the oldest version of Python that is supported. * https://devguide.python.org/versions
cclauss
changed the title
|
@kkoopa Your review, please. This puts README.md, AppVeyor, and GitHub Actions in sync on which versions to test. |
kkoopa
pushed a commit
that referenced
this pull request
Feb 21, 2025
…, 21, and 22 (#983) * AppVeyor: Test on a supported version of Python Python 3.9 is the oldest version of Python that is supported. * https://devguide.python.org/versions * node-gyp > v10 * versions 8, 10, 12, 14, 16, 17, 18, 19, 20, 21, and 22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested versions 8, 10, 12, 14, 16, 17, 18, 19, 20, 21, and 22.
Test supported Node.js versions before unsupported versions because each test takes ~5 minutes.
Test on the most current Visual Studio possible for each nodejs_version.
Test on the oldest supported Python version when possible (currently py39).
For all supported Node.js versions also test on the newest Python (currently py313).
Test results: https://ci.appveyor.com/project/RodVagg/nan
Visual Studio 2017 image tops out at Python 3.8 which is end-of-life.
Visual Studio 2019 and 2022 images top out at Python 3.13.
node-gypissues related tonan: https://github.com/nodejs/node-gyp/issues?q=label%3Anodejs%2FnanThe Node.js v23 tests are commented out waiting for:
The Python 3.12 and 3.13 tests are commented out waiting for:package.json: Upgrade node-gyp to support Python >= v3.12 #985 because of:distutils is removed in Python 3.12 node-gyp#2869@kkoopa Your review, please. These changes enable us to focus on the two issues above.