-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Vite to v3/v4 #1
Conversation
- vite to latest 3.x.x release - rollup to latest 2.x.x release - updates pnpm-lock.yaml version to 5.4 - added "WebWorker" to "compilerOptions.lib" in tsconfig.json; not sure if needed but will not build without it because of type issues in dependencies
Will review ASAP, thanks very much |
Vite v4 came out recently as well so will probably want to tweak this for that version. It also supports |
This removes a "deprecated" warning.
Just bumped all versions of dependencies up to the latest, including |
I can't see any issues with this from looking at the changes. I'll test it out tomorrow and merge if all is well. I'd like to get #2 ironed out too before releasing a major version bump. Could also be good to do that before a RC. |
Just to update, I tested this myself on my template and it seems to build without issue. |
Appears to be a reproduction of vitejs/vite#9813. If that gets resolved we can remove this, it shouldn't be necessary from what I can tell. |
Can't see any issues with updating rollup. We only hook into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not experienced at developing Vite plugins but giving this a shot. Keeping this as draft for now as we work on it.
vite
to the latest3.x.x
version.rollup
to the latest2.x.x
version; mainly had to bump this to fix some typing issues during build because of mismatched dependencies between rollup and Vite. There is also a newer major version (3.x.x) but it isn't supported by Vite 3.pnpm-lock.yaml
version to5.4
."WebWorker"
to"compilerOptions.lib"
intsconfig.json
; not sure if this is needed but will not build without it because of type issues in dependencies."skipLibCheck": true
into"compilerOptions"
also works, but wasn't sure if there was an important reason not to have it.This successfully builds and when used in my
nodecg-vue-ts-template
, allows that to successfully build as well. You may need to check the Vite migration guide yourself to see if I missed anything as I'm not great at fully checking it when I didn't write the plugin.We should also probably bump the other dependencies too, at least to minor versions, but I wanted to bump the least amount possible to see what was needed to get this to build.