wip: fast build only amd64 #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing since we're not going to use this PR as-is. We definitely would benefit from a faster CI feedback loop, but I think routinely disabling one half of the build would introduce other bugs. Would be good to do more thinking about how to make platforms an optional switch for some PRs, those where it would specifically be beneficial. One alternative way is temporary commits on the PR branch that edit the platforms used, which are then dropped and retested with full CI before merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
QEMU arm builds slow builds down a lot. With AMD only, CI would take around 10 min, with ARM as well, it's 60min.
For faster feedback loops it could make sense to be able to run CI with AMD only.
The way I've set it up is definitely not good, but it's a POC. Could be helpful for @joverlee521 while working on #155 for example.