richworkspace css changes

[TSI-mahendramane]

RichWorkspace CSS changes

[tsdicloud]

What is theupstream change the backport refers to?

[tsdicloud]

Please remove function.scss as this is an forbidden obfuscation

[tsdicloud]

It is not allowed to check in webpacks

[tsdicloud]

scss generated icons are not allowed to be checked in

[tsdicloud]

Hardcoded inclusion of addition stylesheets is not allowed (like in Editor.vue).
(->theming?)

[tsdicloud]

No hardcoded icons!
Must use npm run --if-present sass:icons

[tsdicloud]

We have to use the standard variables from nextmcloud/server/core/css/variables.scss
as we must stay within the standard.

E.g.:
** WRONG **
var(--color-background-magenta)

** RIGHT (if we need to redefine at all!) **
var(--color-main-background)

If Nextcloud uses hardcoded value, we can raise upstream PR as Nextcloud wants to be portable with their themes system.

[TSI-mahendramane]

It is not allowed to check in webpacks
As discussed with platform team all bunddle files need to push along with changes

[TSI-mahendramane]

var(--color-background-magenta)

No hardcoded icons! Must use npm run --if-present sass:icons

This command is not useful as we are using custom icons here

[tsdicloud]

Can you please learn how Nextcloud theming and generation of icons from source images works for SCSS theming?
If I write you a review, comment, there is deep reasoning behind it.

[TSI-mahendramane]

Please remove function.scss as this is an forbidden obfuscation

Removed , as suggested

[TSI-mahendramane]

Hardcoded inclusion of addition stylesheets is not allowed (like in Editor.vue). (->theming?)

Removed additional hard coded stylesheet,as suggested

[TSI-mahendramane]

Please remove function.scss as this is an forbidden obfuscation

Removed function.scss , as suggested

[TSI-mahendramane]

Hardcoded inclusion of addition stylesheets is not allowed (like in Editor.vue). (->theming?)

Removed hardcoded additional stylesheet from vue component, as suggested

[TSI-mahendramane]

No hardcoded icons! Must use npm run --if-present sass:icons

removed hard coded icons, as suggested

[TSI-mahendramane]

It is not allowed to check in webpacks

Resolved

[TSI-mahendramane]

scss generated icons are not allowed to be checked in

Working on it , will generate new PR for that.