Cache hasAvatar to avoid call background flickering #4379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever the speaker changes, the avatar background can flicker due to HTTP calls. This fix improves it a bit by caching the information whether the user has an avatar or not, so allows a less delayed loading of the avatar background. Signed-off-by: Vincent Petry <[email protected]>
|
@ma12-co this PR is only about the background and that one looks stable/fine in your video. For the avatar's "white circle" please also check out nextcloud-libraries/nextcloud-vue#1457. Make sure to repeat the operations multiple times: the first time you'll still see artifacts and after the cache is populated, switching should not show any glitch (except for "stop following" which I observed locally) |
Signed-off-by: Vincent Petry <[email protected]>
|
Adjusted to use browser storage. However I'm not using the |
marcoambrosini
approved these changes
Oct 16, 2020
Merged
5 tasks
|
backport to stable20 here #4514 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the speaker changes, the avatar background can flicker due to
HTTP calls. This fix improves it a bit by caching the information
whether the user has an avatar or not, so allows a less delayed loading of
the avatar background.
This only affects the avatar background.
For the avatar itself, you also need nextcloud-libraries/nextcloud-vue#1457 in place.
Best is to test both together.