pass all props to the trigger slot of NcPopover

Signed-off-by: Julien Veyssier <[email protected]>
nextcloud · Nov 18, 2024 · be8c2f3 · be8c2f3
1 parent d6c20a3
commit be8c2f3
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 21 deletions.
diff --git a/src/components/UserPopover.vue b/src/components/UserPopover.vue
@@ -34,8 +34,9 @@
 				</div>
 			</div>
 		</div>
-		<template #trigger>
-			<slot />
+		<!-- See https://nextcloud-vue-components.netlify.app/#/Components/NcPopover -->
+		<template #trigger="{ attrs }">
+			<slot name="trigger" v-bind="attrs" />
 		</template>
 	</NcPopover>
 </template>

diff --git a/src/views/GithubIssuePrReferenceWidget.vue b/src/views/GithubIssuePrReferenceWidget.vue
@@ -72,13 +72,16 @@
 						:shown="showObjectAuthorPopover"
 						:subject-type="richObject.github_type"
 						:subject-id="richObject.id">
-						<a :href="'https://github.com/' + richObject.user.login"
-							target="_blank"
-							class="author-link"
-							@mouseenter="showObjectAuthorPopover = true"
-							@mouseleave="showObjectAuthorPopover = false">
-							{{ t('integration_github', 'by {creator}', { creator: richObject.user.login }) }}
-						</a>
+						<template #trigger="{ attrs }">
+							<a v-bind="attrs"
+								:href="'https://github.com/' + richObject.user.login"
+								target="_blank"
+								class="author-link"
+								@mouseenter="showObjectAuthorPopover = true"
+								@mouseleave="showObjectAuthorPopover = false">
+								{{ t('integration_github', 'by {creator}', { creator: richObject.user.login }) }}
+							</a>
+						</template>
 					</UserPopover>
 					&nbsp;
 					<span v-tooltip.top="{ content: subTextTooltip }"
@@ -112,12 +115,14 @@
 					:shown="showCommentAvatarPopover"
 					:subject-type="richObject.github_type"
 					:subject-id="richObject.id">
-					<NcAvatar
-						class="author-avatar"
-						:is-no-user="true"
-						:url="commentAuthorAvatarUrl"
-						@mouseenter.native="showCommentAvatarPopover = true"
-						@mouseleave.native="showCommentAvatarPopover = false" />
+					<template #trigger="{ attrs }">
+						<NcAvatar v-bind="attrs"
+							class="author-avatar"
+							:is-no-user="true"
+							:url="commentAuthorAvatarUrl"
+							@mouseenter.native="showCommentAvatarPopover = true"
+							@mouseleave.native="showCommentAvatarPopover = false" />
+					</template>
 				</UserPopover>
 				<span class="comment--content--bubble-tip" />
 				<span class="comment--content--bubble">
@@ -126,12 +131,15 @@
 							:shown="showCommentAuthorPopover"
 							:subject-type="richObject.github_type"
 							:subject-id="richObject.id">
-							<strong @mouseenter="showCommentAuthorPopover = true"
-								@mouseleave="showCommentAuthorPopover = false">
-								<a :href="commentAuthorUrl" target="_blank" class="author-link comment-author-display-name">
-									{{ richObject.github_comment?.user?.login }}
-								</a>
-							</strong>
+							<template #trigger="{ attrs }">
+								<strong v-bind="attrs"
+									@mouseenter="showCommentAuthorPopover = true"
+									@mouseleave="showCommentAuthorPopover = false">
+									<a :href="commentAuthorUrl" target="_blank" class="author-link comment-author-display-name">
+										{{ richObject.github_comment?.user?.login }}
+									</a>
+								</strong>
+							</template>
 						</UserPopover>
 						&nbsp;
 						<span v-tooltip.top="{ content: commentedAtTooltip }"