Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sveltekit): update server-side "SignIn" and "SignOut" button components #10144

Merged
merged 2 commits into from
Feb 28, 2024
Merged

fix(sveltekit): update server-side "SignIn" and "SignOut" button components #10144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13bc89a
fix: name SignOut button slot "submitButton" as well
ndom91 Feb 27, 2024
02db275
fix: cleanup SignIn button types and label
ndom91 Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/frameworks-sveltekit/src/lib/components/SignIn.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import type { signIn } from "$lib/actions"

export let className = ""
export let provider: Parameters<typeof signIn>[0]
export let provider: Partial<Parameters<typeof signIn>[0]> = ""
/** The path to the FormAction file in your route. @default signin */
export let signInPage = "signin"
export let options: Parameters<typeof signIn>[1] | undefined = undefined
Expand Down Expand Up @@ -59,7 +59,7 @@
/>
</slot>
{/if}
<button style="width: 100%" type="submit"
><slot name="submitButton">Sign in with {provider}</slot></button
>
<button type="submit">
<slot name="submitButton">Signin{provider ? `with ${provider}` : ""}</slot>
</button>
</form>
4 changes: 3 additions & 1 deletion packages/frameworks-sveltekit/src/lib/components/SignOut.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,7 @@
<input type="hidden" name="redirectTo" value={options.redirectTo} />
{/if}
{/if}
<button type="submit"><slot /></button>
<button type="submit">
<slot name="submitButton">Sign Out</slot>
</button>
</form>
Loading