Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goreleaser adding version to binaries #519

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

goreleaser adding version to binaries #519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/push_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
if: steps.list-changed.outputs.changed == 'true'
run: |
TAG=test GOOS=linux GOARCH=amd64 make ci/build
sudo cp ./dist/nri-prometheus-nix_linux_amd64/nri-prometheus ./bin/nri-prometheus
sudo cp ./dist/nri-prometheus-nix_linux_amd64_v1/nri-prometheus ./bin/nri-prometheus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like it hardcoded here. It's very easy to miss. What if we move to version 2 or 3 for amd64, it will again fail and will need to be fixed.
Maybe it is better to use something like:
ls -t nri-prometheus-nix_linux_amd64* | head -n1
to decide the folder to use, and then copy file from there.

DOCKER_BUILDKIT=1 docker build -t e2e/nri-prometheus:test . -f Dockerfile.dev
minikube image load e2e/nri-prometheus:test
- name: Test install charts
Expand Down
Loading