Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data_partition): fix issue with enable attribute #1034

Merged
merged 2 commits into from
Jul 11, 2023
Merged

fix(data_partition): fix issue with enable attribute #1034

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
641281d
fix(data_partition): fix issue with enable attribute
RavitejaSurampudi Jul 7, 2023
22434d9
fix(data_partition): addition of a comment to not add omitempty from …
pranav-new-relic Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/logconfigurations/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,9 @@ type LogConfigurationsUpdateDataPartitionRuleInput struct {
// The description of the data partition rule.
Description string `json:"description,omitempty"`
// Whether or not this data partition rule is enabled.
Enabled bool `json:"enabled,omitempty"`
// NOTE: DO NOT add 'omitempty' to the JSON description of Enabled as fetched from Tutone.
// It omits 'enabled' even if the calling service sends it as 'false', which is why 'omitempty' has been manually discarded.
Enabled bool `json:"enabled"`
// Unique data partition rule identifier.
ID string `json:"id"`
// The criteria of the data partition rule.
Expand Down