Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alerts): Removed omitempty from RunbookURL in NrqlConditionUpdateBase #1030

Merged
merged 2 commits into from
May 3, 2023
Merged

fix(alerts): Removed omitempty from RunbookURL in NrqlConditionUpdateBase #1030

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ca0977
fix(alerts):Removed omitempty from RunbookURL in NrqlConditionUpdateBase
usfdmiller Apr 28, 2023
deb6e58
Merge branch 'main' into fix/2332-removing-runbook-url-from-nrql-aler…
usfdmiller May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/alerts/nrql_conditions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ type NrqlConditionUpdateBase struct {
Enabled bool `json:"enabled"`
Name string `json:"name,omitempty"`
Nrql NrqlConditionUpdateQuery `json:"nrql"`
RunbookURL string `json:"runbookUrl,omitempty"`
RunbookURL string `json:"runbookUrl"`
Terms []NrqlConditionTerm `json:"terms,omitempty"`
Type NrqlConditionType `json:"type,omitempty"`
ViolationTimeLimit NrqlConditionViolationTimeLimit `json:"violationTimeLimit,omitempty"`
Expand Down