Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: netlify Image cdn support #710

Merged
merged 36 commits into from
Dec 1, 2023
Merged

feat: netlify Image cdn support #710

merged 36 commits into from
Dec 1, 2023

Conversation

kathmbeck
Copy link
Contributor

@kathmbeck kathmbeck commented Nov 15, 2023

Summary

Support Netlify Image CDN in gatsby build plugin. This requires use of the NETLIFY_IMAGE_CDN env var to be set to true and for remote image domains config to be set in the netlify.toml file.

Test plan

  1. Visit the Deploy Preview ([Image CDN])

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was
published correctly.

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for netlify-plugin-gatsby-demo-v5 ready!

Name Link
🔨 Latest commit d0bfba6
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-gatsby-demo-v5/deploys/65674a731a39df000896e4b0
😎 Deploy Preview https://deploy-preview-710--netlify-plugin-gatsby-demo-v5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for netlify-plugin-gatsby-demo ready!

Name Link
🔨 Latest commit d0bfba6
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-gatsby-demo/deploys/65674a736e0f6600088cdd22
😎 Deploy Preview https://deploy-preview-710--netlify-plugin-gatsby-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

plugin/src/templates/image.ts Outdated Show resolved Hide resolved
@kathmbeck kathmbeck changed the title [wip]: netlify Image cdn support feat: netlify Image cdn support Nov 21, 2023
docs/image-cdn.md Outdated Show resolved Hide resolved
docs/image-cdn.md Outdated Show resolved Hide resolved
@kathmbeck kathmbeck marked this pull request as ready for review November 27, 2023 16:31
@kathmbeck kathmbeck requested a review from a team as a code owner November 27, 2023 16:31
@kathmbeck kathmbeck requested a review from pieh November 28, 2023 14:15
docs/image-cdn.md Outdated Show resolved Hide resolved
Co-authored-by: Michal Piechowiak <[email protected]>
@pieh pieh merged commit 6b3baa4 into main Dec 1, 2023
@pieh pieh deleted the image-cdn-support branch December 1, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants