Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Update Signing Message for Funding Lock and Commitment Lock (with Pending HTLC) #17

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

jjyr
Copy link
Contributor

@jjyr jjyr commented Mar 7, 2025

This PR update the signing message of funding lock and commitment lock(with pending htlc).

In the original code, the signing message was tx_hash. This approach faces challenges during script upgrades because the cell_dep field in the transaction became invalid, which causes the entire transaction invalid.

To resolve this, we empty RawTransaction#cell_dep field, then use blake2b_256(&raw_tx.as_slice()) to get the signing message.

@jjyr jjyr requested a review from quake March 18, 2025 16:54
@quake quake marked this pull request as ready for review March 19, 2025 00:36
@quake quake merged commit d65bf37 into nervosnetwork:main Mar 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants