Use more specific typehints

nepada · Nov 9, 2024 · 67feaf2 · 67feaf2
1 parent 168d1a8
commit 67feaf2
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/src/MessageBus/CommandBusDynamicMethodThrowTypeExtension.php b/src/MessageBus/CommandBusDynamicMethodThrowTypeExtension.php
@@ -64,7 +64,7 @@ public function getThrowTypeFromMethodCall(MethodReflection $methodReflection, M
     }
 
     /**
-     * @return Type[]
+     * @return list<Type>
      */
     private function getHandlerThrowTypes(string $commandType, Scope $scope): array
     {

diff --git a/src/MessageBus/CommandHandlerResolver.php b/src/MessageBus/CommandHandlerResolver.php
@@ -14,19 +14,19 @@ class CommandHandlerResolver
 {
 
     /**
-     * @var string[]
+     * @var array<string>
      */
     private array $scanDirectories;
 
     /**
-     * @var string[]|null
+     * @var array<class-string<CommandHandler>, class-string>|null
      */
     private ?array $commandTypeByHandlerType = null;
 
     private MessageTypeExtractor $messageTypeExtractor;
 
     /**
-     * @param string[] $scanDirectories
+     * @param array<string> $scanDirectories
      */
     public function __construct(array $scanDirectories, MessageTypeExtractor $messageTypeExtractor)
     {
@@ -35,7 +35,7 @@ public function __construct(array $scanDirectories, MessageTypeExtractor $messag
     }
 
     /**
-     * @return string[]
+     * @return list<string>
      */
     public function getHandlerClasses(string $handledCommandType): array
     {
@@ -50,7 +50,7 @@ public function getHandlerClasses(string $handledCommandType): array
     }
 
     /**
-     * @return string[]
+     * @return array<class-string<CommandHandler>, class-string>
      */
     private function getCommandTypeByHandlerType(): array
     {
@@ -83,7 +83,7 @@ private function getCommandTypeByHandlerType(): array
     }
 
     /**
-     * @return string[]
+     * @return list<string>
      */
     private function getAllClasses(): array
     {

diff --git a/src/MessageBus/CommandTypeExtractor.php b/src/MessageBus/CommandTypeExtractor.php
@@ -11,6 +11,9 @@
 class CommandTypeExtractor
 {
 
+    /**
+     * @return class-string|null
+     */
     public function extractCommandType(MethodCall $methodCall, Scope $scope): ?string
     {
         if (count($methodCall->args) === 0) {
-Original file line number
+Diff line change
@@ Expand Up @@
         }
         /**
-         * @return Type[]
+         * @return list<Type>
          */
         private function getHandlerThrowTypes(string $commandType, Scope $scope): array
         {
@@ Expand Down @@