Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add --adaptive-lsp-server-enabled and remove --background-service-enabled for F# #2196

Closed
wants to merge 4 commits into from

Conversation

adelarsq
Copy link
Contributor

This change handle loading of projects and type checking in an adaptive way.

Depends on fsautocomplete 0.58.0 or greater.

Related pull requests:
ionide/FsAutoComplete#1007
ionide/ionide-vscode-fsharp#1781

@glepnir
Copy link
Member

glepnir commented Oct 15, 2022

change your commit msg to fix: add --adaptive-lsp-server-enabled for F

@adelarsq adelarsq changed the title Add --adaptive-lsp-server-enabled for F# LSP fix: add --adaptive-lsp-server-enabled for F# Oct 15, 2022
@adelarsq adelarsq changed the title fix: add --adaptive-lsp-server-enabled for F# fix: add --adaptive-lsp-server-enabled and remove --background-service-enabled for F# Oct 15, 2022
@glepnir
Copy link
Member

glepnir commented Oct 15, 2022

ci failed . please check the https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md. you commit msg should not include an upper word like Remove . it should be fix: remove the field ... use git commit --amend to change your commit message the force push would be better .

@adelarsq
Copy link
Contributor Author

adelarsq commented Oct 15, 2022

@glepnir That was unexpected. Do you think that is better to create another branch for this?

@glepnir
Copy link
Member

glepnir commented Oct 15, 2022

sure. closed then.

@glepnir glepnir closed this Oct 15, 2022
@adelarsq adelarsq deleted the patch-1 branch October 15, 2022 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants