Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legger til integrasjonstest baseklasse med med postgresSql testcontainer og embedded kafka. #1057

Merged
merged 43 commits into from
Jan 10, 2024
Merged
Show file tree
Hide file tree
Changes from 40 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
a1756ac
WIP erstattet embedded postgres med TC.
albrektsson Dec 19, 2023
3ad3f5b
Fikser applikasjonoppstart.
ramrock93 Dec 19, 2023
0a35ce4
Fikser automatisk flyway migrering.
ramrock93 Dec 20, 2023
23b556b
Fikser baseclass testoppsett.
ramrock93 Dec 20, 2023
0475100
Prøver å mocke pepClient
ramrock93 Dec 20, 2023
21f46ac
Erstatter KafkaContainer med EmbeddedKafka.
ramrock93 Dec 21, 2023
fba27cc
Fikser flere tester
ramrock93 Dec 21, 2023
39d5013
Fikser flere tester
ramrock93 Dec 21, 2023
eabd872
Bruker AbstractContainerBaseTest for BrevServiceImplTest
ramrock93 Jan 3, 2024
95a3350
Bruker AbstractContainerBaseTest for SøknadRepositoryTest.
ramrock93 Jan 3, 2024
a9f89a1
Bruker AbstractContainerBaseTest for fordel testene.
ramrock93 Jan 3, 2024
458cd54
Bruker AbstractContainerBaseTest for ArbeidsgivereRoutesTest.
ramrock93 Jan 3, 2024
d892f78
Bruker setup function for cleanup.
ramrock93 Jan 3, 2024
16b5a15
Bruker AbstractContainerBaseTest for MetrikkJobbTest.
ramrock93 Jan 3, 2024
5cd6bc6
Bruker AbstractContainerBaseTest for SjekkOmUtløptJobbTest.
ramrock93 Jan 3, 2024
52d251e
Bruker AbstractContainerBaseTest for JournalpostServiceTest.
ramrock93 Jan 3, 2024
e680175
Fikser GosysRoutesTest.
ramrock93 Jan 3, 2024
3106454
Bruker AbstractContainerBaseTest for KopierJournalpostRouteTest.
ramrock93 Jan 3, 2024
8e90a7a
Bruker AbstractContainerBaseTest for PunsjJournalpostMetrikkRepositor…
ramrock93 Jan 4, 2024
cb7f933
Bruker AbstractContainerBaseTest for PunsjJournalpostRepositoryTest.
ramrock93 Jan 4, 2024
a36d6cc
Bruker AbstractContainerBaseTest for KorrigeringInntektsmeldingDtoRou…
ramrock93 Jan 4, 2024
5dc05fb
Refaktorere gjentakende kall for opprettelse av ny søknad.
ramrock93 Jan 4, 2024
80de6a1
Refaktorere gjentakende kall for henting, oppdatering og validering.
ramrock93 Jan 4, 2024
b5219f6
Bruker AbstractContainerBaseTest for NotatRoutesTest.
ramrock93 Jan 4, 2024
9d24409
Bruker AbstractContainerBaseTest for OmsorgspengerAleneOmsorgRoutesTest.
ramrock93 Jan 4, 2024
6b45e61
Bruker AbstractContainerBaseTest for OmsorgspengerKroniskSyktBarnRout…
ramrock93 Jan 4, 2024
c14e62a
Bruker AbstractContainerBaseTest for PersonApiTest.
ramrock93 Jan 5, 2024
95832a8
Bruker AbstractContainerBaseTest for SakServiceTest.
ramrock93 Jan 5, 2024
6a5b8e9
Bruker AbstractContainerBaseTest for OmsorgspengerMidlertidigAleneRou…
ramrock93 Jan 5, 2024
8e9579a
Bruker AbstractContainerBaseTest for OmsorgspengerutbetalingRoutesTest.
ramrock93 Jan 5, 2024
3eedfa7
Bruker AbstractContainerBaseTest for PleiepengerLivetsSluttfaseRoutes…
ramrock93 Jan 5, 2024
c350e74
Bruker AbstractContainerBaseTest for MappeRepositoryTest.
ramrock93 Jan 5, 2024
c23366e
Bruker AbstractContainerBaseTest for PleiepengersyktbarnTests.
ramrock93 Jan 5, 2024
a735b95
Bruker AbstractContainerBaseTest for K9PunsjApplicationTests.
ramrock93 Jan 5, 2024
646d979
Flytter init ut av companion object.
ramrock93 Jan 8, 2024
75c1c30
Fikser PeriodeDtoTest.
ramrock93 Jan 8, 2024
9299a9f
Merge branch 'master' into testcontainer-poc
ramrock93 Jan 8, 2024
028388e
Fjerner utkommenter kode.
ramrock93 Jan 8, 2024
5d94e72
Bruker AbstractContainerBaseTest for AksjonspunktRepositoryTest.
ramrock93 Jan 8, 2024
cc19a8a
Bruker AbstractContainerBaseTest for SoknadIntegrasjonsTest.
ramrock93 Jan 8, 2024
61e5958
Bruker dynamisk port på wiremock server.
ramrock93 Jan 8, 2024
531a178
Fjerner baselineOnMigrate og clean-on-validation-error.
ramrock93 Jan 10, 2024
c2035e0
Konfigurerer datasource.
ramrock93 Jan 10, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 23 additions & 9 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@
<zonky-postgresql.version>13.4.0</zonky-postgresql.version>
<mockk.version>1.13.8</mockk.version>
<jsonassert.version>1.5.1</jsonassert.version>
<testcontainers.version>1.19.3</testcontainers.version>
<springmockk.version>4.0.2</springmockk.version>

<!-- pdf -->
<openhtmltopdf.version>1.0.10</openhtmltopdf.version>
Expand All @@ -69,9 +71,9 @@
<dependencyManagement>
<dependencies>
<dependency>
<groupId>io.zonky.test.postgres</groupId>
<artifactId>embedded-postgres-binaries-bom</artifactId>
<version>${zonky-postgresql.version}</version>
<groupId>org.testcontainers</groupId>
<artifactId>testcontainers-bom</artifactId>
<version>${testcontainers.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down Expand Up @@ -99,6 +101,10 @@
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-validation</artifactId>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-jdbc</artifactId>
</dependency>
<dependency>
<groupId>org.springframework.kafka</groupId>
<artifactId>spring-kafka</artifactId>
Expand Down Expand Up @@ -218,9 +224,9 @@

<!-- Testing & Mocks -->
<dependency>
<groupId>io.mockk</groupId>
<artifactId>mockk-jvm</artifactId>
<version>${mockk.version}</version>
<groupId>com.ninja-squad</groupId>
<artifactId>springmockk</artifactId>
<version>${springmockk.version}</version>
<scope>test</scope>
</dependency>
<dependency>
Expand All @@ -235,9 +241,17 @@
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.zonky.test</groupId>
<artifactId>embedded-postgres</artifactId>
<version>${embedded-postgres.version}</version>
<groupId>no.nav.security</groupId>
<artifactId>token-validation-spring-test</artifactId>
<version>${token-support.version}</version>
</dependency>
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>postgresql</artifactId>
</dependency>
<dependency>
<groupId>org.springframework.kafka</groupId>
<artifactId>spring-kafka-test</artifactId>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
12 changes: 1 addition & 11 deletions src/main/kotlin/no/nav/k9punsj/K9PunsjApplication.kt
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,19 @@ import com.fasterxml.jackson.databind.PropertyNamingStrategies
import com.fasterxml.jackson.databind.SerializationFeature
import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule
import de.huxhorn.sulky.ulid.ULID
import no.nav.k9punsj.configuration.DbConfiguration
import no.nav.k9punsj.configuration.hikariConfig
import no.nav.k9punsj.utils.UlidDeserializer
import org.springframework.boot.Banner
import org.springframework.boot.autoconfigure.SpringBootApplication
import org.springframework.boot.autoconfigure.flyway.FlywayAutoConfiguration
import org.springframework.boot.autoconfigure.web.servlet.error.ErrorMvcAutoConfiguration
import org.springframework.boot.runApplication
import org.springframework.boot.web.embedded.netty.NettyReactiveWebServerFactory
import org.springframework.boot.web.reactive.server.ReactiveWebServerFactory
import org.springframework.context.annotation.Bean
import org.springframework.http.converter.json.Jackson2ObjectMapperBuilder
import org.springframework.scheduling.annotation.EnableScheduling
import javax.sql.DataSource

@EnableScheduling
@SpringBootApplication(exclude = [ErrorMvcAutoConfiguration::class, FlywayAutoConfiguration::class])
@SpringBootApplication(exclude = [ErrorMvcAutoConfiguration::class])
class K9PunsjApplication {

@Bean
Expand All @@ -37,12 +33,6 @@ class K9PunsjApplication {
fun reactiveWebServerFactory(): ReactiveWebServerFactory {
return NettyReactiveWebServerFactory()
}

@Bean
@StandardProfil
fun databaseInitializer(dbConfiguration: DbConfiguration): DataSource {
return hikariConfig(dbConfiguration)
}
}

fun main(args: Array<String>) {
Expand Down
36 changes: 0 additions & 36 deletions src/main/kotlin/no/nav/k9punsj/configuration/DbConfiguration.kt

This file was deleted.

26 changes: 0 additions & 26 deletions src/main/kotlin/no/nav/k9punsj/configuration/HikariConfig.kt

This file was deleted.

49 changes: 0 additions & 49 deletions src/main/kotlin/no/nav/k9punsj/configuration/Postgres.kt

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
package no.nav.k9punsj.kafka

import no.nav.k9punsj.IkkeTestProfil
import org.slf4j.Logger
import org.slf4j.LoggerFactory
import org.springframework.kafka.core.KafkaTemplate
import org.springframework.stereotype.Component

@Component
@IkkeTestProfil
class KafkaHendelseProducer(
private val kafkaTemplate: KafkaTemplate<String, String>
) : HendelseProducer {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import org.springframework.web.reactive.function.server.ServerResponse
import org.springframework.web.reactive.function.server.buildAndAwait

@Service
internal class AuthenticationHandler(
class AuthenticationHandler(
multiIssuerProperties: MultiIssuerProperties
) {

Expand Down
11 changes: 6 additions & 5 deletions src/main/resources/application.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
spring:
flyway:
enabled: true
baselineOnMigrate: true
clean-on-validation-error: true

management:
health:
diskspace:
Expand Down Expand Up @@ -74,11 +80,6 @@ no.nav:
accepted_audience: ${APP_NAISSTS_aud}
proxyUrl:

db:
url: ${DEFAULTDS_URL}
username: ${DEFAULTDS_USERNAME}
password: ${DEFAULTDS_PASSWORD}
vault_mountpath: ${DEFAULTDS_VAULT_MOUNTPATH}
abac:
system_user: ${SYSTEMBRUKER_USERNAME}
system_user_password: ${SYSTEMBRUKER_PASSWORD}
Expand Down
Loading
Loading