-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add CRUD to themed example #4785
base: master
Are you sure you want to change the base?
Conversation
Netlify deploy preview |
}, [listPath, router]); | ||
|
||
return ( | ||
<CrudProvider<Employee> dataSource={employeesDataSource} dataSourceCache={employeesCache}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll expose the dataGrid
slot to the Crud
component so we can just use that component here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to just add a TODO comment here for this for now as i guess we will only be able to adjust here after the next release once we merge #4786
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just noticed a few things that probably we can improve:
- Add:
import PersonIcon from '@mui/icons-material/Person';
// ...
{
segment: 'employees',
title: 'Employees',
icon: <PersonIcon />,
pattern: 'employees{/:employeeId}*',
},
// ...
to the navigation to show employees pages and breadcrumbs.
- There's no spacing above and below the action icon buttons, not sure if we should solve that in the template itself or in the CRUD components? (just checked and all looks fine in the standard version so I guess we can fix it somehow for this template)

- The form input labels need spacing below, I guess this one should probably be fixed in the template?

Thanks! Addressed all of this in the theme of the template |
Crud