Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Deprecate Toolpad Studio #45613

Merged
merged 6 commits into from
Mar 19, 2025
Merged

[docs] Deprecate Toolpad Studio #45613

merged 6 commits into from
Mar 19, 2025

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Mar 18, 2025

  • Remove Toolpad Studio from the homepage showcases
  • Remove Toolpad Studio from the docs menu

@Janpot Janpot added the docs Improvements or additions to the documentation label Mar 18, 2025
@mui-bot
Copy link

mui-bot commented Mar 18, 2025

Netlify deploy preview

https://deploy-preview-45613--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 50252be

@Janpot Janpot marked this pull request as ready for review March 19, 2025 10:35
@bharatkashyap
Copy link
Member

  1. We should change the structure of the product switcher:
Screenshot 2025-03-19 at 4 27 35 PM

The heading is not needed any more, and the product can span the entire width of the menu

  1. We also need to remove this section from the landing page:
Screenshot 2025-03-19 at 4 31 39 PM

@Janpot
Copy link
Member Author

Janpot commented Mar 19, 2025

  1. We also need to remove this section from the landing page:

That's handled in mui/toolpad#4756

@Janpot
Copy link
Member Author

Janpot commented Mar 19, 2025

The heading is not needed any more, and the product can span the entire width of the menu

This doesn't look right imo, the header seems essential information. The screenshot you shared looks great to me. As expected.

Screenshot 2025-03-19 at 12 11 10

@bharatkashyap
Copy link
Member

This doesn't look right imo, the header seems essential information. The screenshot you shared looks great to me. As expected.

Does the half-width item in the full-width menu seem okay to you? My issue was just with that asymmetry, although on second viewing it seems passable as well. The header is okay for me

@Janpot
Copy link
Member Author

Janpot commented Mar 19, 2025

Does the half-width item in the full-width menu seem okay to you?

It looks fine to me, but I'm not a designer.

@prakhargupta1
Copy link
Member

prakhargupta1 commented Mar 19, 2025

I gave Toolpad Core full width and moved the Beta chip next to it. This looks fine to me.
Screenshot 2025-03-19 at 7 51 16 PM

@Janpot Janpot merged commit 4d0f05c into mui:master Mar 19, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants