-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[l10n] Add Danish (da-DK) locale #29485
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
10efeec
Updating with danish language
mikk5829 dd3d0aa
yarn lint & yarn prettier
mbrookes 1774f3a
Merge remote-tracking branch 'upstream/master' into patch-1
michaldudak 319c5ac
Add Danish to the list of supported languages
michaldudak afee13d
Remove redundant dangerfile
michaldudak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,160 @@ | ||
// inspire by reacts dangerfile | ||
// danger has to be the first thing required! | ||
const { danger, markdown } = require('danger'); | ||
const { exec } = require('child_process'); | ||
const { loadComparison } = require('./scripts/sizeSnapshot'); | ||
|
||
const azureBuildId = process.env.AZURE_BUILD_ID; | ||
const azureBuildUrl = `https://dev.azure.com/mui-org/Material-UI/_build/results?buildId=${azureBuildId}`; | ||
const dangerCommand = process.env.DANGER_COMMAND; | ||
|
||
const parsedSizeChangeThreshold = 300; | ||
const gzipSizeChangeThreshold = 100; | ||
|
||
const UPSTREAM_REMOTE = 'danger-upstream'; | ||
|
||
/** | ||
* This is mainly used for local development. It should be executed before the | ||
* scripts exit to avoid adding internal remotes to the local machine. This is | ||
* not an issue in CI. | ||
*/ | ||
async function reportBundleSizeCleanup() { | ||
await git(`remote remove ${UPSTREAM_REMOTE}`); | ||
} | ||
|
||
/** | ||
* creates a callback for Object.entries(comparison).filter that excludes every | ||
* entry that does not exceed the given threshold values for parsed and gzip size | ||
* @param {number} parsedThreshold | ||
* @param {number} gzipThreshold | ||
*/ | ||
function createComparisonFilter(parsedThreshold, gzipThreshold) { | ||
return (comparisonEntry) => { | ||
const [, snapshot] = comparisonEntry; | ||
return ( | ||
Math.abs(snapshot.parsed.absoluteDiff) >= parsedThreshold || | ||
Math.abs(snapshot.gzip.absoluteDiff) >= gzipThreshold | ||
); | ||
}; | ||
} | ||
|
||
/** | ||
* checks if the bundle is of a package e.b. `@mui/material` but not | ||
* `@mui/material/Paper` | ||
* @param {[string, any]} comparisonEntry | ||
*/ | ||
function isPackageComparison(comparisonEntry) { | ||
const [bundleKey] = comparisonEntry; | ||
return /^@[\w-]+\/[\w-]+$/.test(bundleKey); | ||
} | ||
|
||
/** | ||
* Generates a user-readable string from a percentage change | ||
* @param {number} change | ||
* @param {string} goodEmoji emoji on reduction | ||
* @param {string} badEmoji emoji on increase | ||
*/ | ||
function addPercent(change, goodEmoji = '', badEmoji = ':small_red_triangle:') { | ||
const formatted = (change * 100).toFixed(2); | ||
if (/^-|^0(?:\.0+)$/.test(formatted)) { | ||
return `${formatted}% ${goodEmoji}`; | ||
} | ||
return `+${formatted}% ${badEmoji}`; | ||
} | ||
|
||
function generateEmphasizedChange([bundle, { parsed, gzip }]) { | ||
// increase might be a bug fix which is a nice thing. reductions are always nice | ||
const changeParsed = addPercent(parsed.relativeDiff, ':heart_eyes:', ''); | ||
const changeGzip = addPercent(gzip.relativeDiff, ':heart_eyes:', ''); | ||
|
||
return `**${bundle}**: parsed: ${changeParsed}, gzip: ${changeGzip}`; | ||
} | ||
|
||
/** | ||
* Puts results in different buckets wh | ||
* @param {*} results | ||
*/ | ||
function sieveResults(results) { | ||
const main = []; | ||
const pages = []; | ||
|
||
results.forEach((entry) => { | ||
const [bundleId] = entry; | ||
|
||
if (bundleId.startsWith('docs:')) { | ||
pages.push(entry); | ||
} else { | ||
main.push(entry); | ||
} | ||
}); | ||
|
||
return { all: results, main, pages }; | ||
} | ||
|
||
function prepareBundleSizeReport() { | ||
markdown( | ||
`Bundle size will be reported once [Azure build #${azureBuildId}](${azureBuildUrl}) finishes.`, | ||
); | ||
} | ||
|
||
async function reportBundleSize() { | ||
// Use git locally to grab the commit which represents the place | ||
// where the branches differ | ||
const upstreamRepo = danger.github.pr.base.repo.full_name; | ||
const upstreamRef = danger.github.pr.base.ref; | ||
try { | ||
await git(`remote add ${UPSTREAM_REMOTE} https://github.com/${upstreamRepo}.git`); | ||
} catch (err) { | ||
// ignore if it already exist for local testing | ||
} | ||
await git(`fetch ${UPSTREAM_REMOTE}`); | ||
const mergeBaseCommit = await git(`merge-base HEAD ${UPSTREAM_REMOTE}/${upstreamRef}`); | ||
|
||
const detailedComparisonRoute = `/size-comparison?buildId=${azureBuildId}&baseRef=${danger.github.pr.base.ref}&baseCommit=${mergeBaseCommit}&prNumber=${danger.github.pr.number}`; | ||
const detailedComparisonUrl = `https://mui-dashboard.netlify.app${detailedComparisonRoute}`; | ||
|
||
const comparison = await loadComparison(mergeBaseCommit, upstreamRef); | ||
|
||
const { all: allResults, main: mainResults } = sieveResults(Object.entries(comparison.bundles)); | ||
const anyResultsChanges = allResults.filter(createComparisonFilter(1, 1)); | ||
|
||
if (anyResultsChanges.length > 0) { | ||
const importantChanges = mainResults | ||
.filter(createComparisonFilter(parsedSizeChangeThreshold, gzipSizeChangeThreshold)) | ||
.filter(isPackageComparison) | ||
.map(generateEmphasizedChange); | ||
|
||
// have to guard against empty strings | ||
if (importantChanges.length > 0) { | ||
markdown(importantChanges.join('\n')); | ||
} | ||
|
||
const details = `[Details of bundle changes](${detailedComparisonUrl})`; | ||
|
||
markdown(details); | ||
} else { | ||
markdown(`[No bundle size changes](${detailedComparisonUrl})`); | ||
} | ||
} | ||
|
||
async function run() { | ||
switch (dangerCommand) { | ||
case 'prepareBundleSizeReport': | ||
prepareBundleSizeReport(); | ||
break; | ||
case 'reportBundleSize': | ||
try { | ||
await reportBundleSize(); | ||
} finally { | ||
await reportBundleSizeCleanup(); | ||
} | ||
break; | ||
default: | ||
throw new TypeError(`Unrecognized danger command '${dangerCommand}'`); | ||
} | ||
} | ||
|
||
run().catch((error) => { | ||
console.error(error); | ||
process.exit(1); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbrookes has this file been added by accident?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears so