Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron-test): webdriver session not created #1972

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

MaximoLiberata
Copy link
Contributor

This PR fix the error of chromdriver when it attempts to start a new session in browser.

Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.15%. Comparing base (8df668b) to head (37c64df).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1972   +/-   ##
=======================================
  Coverage   81.15%   81.15%           
=======================================
  Files          24       24           
  Lines        1470     1470           
  Branches      349      349           
=======================================
  Hits         1193     1193           
  Misses        193      193           
  Partials       84       84           
Flag Coverage Δ
unittests 81.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 🙏🏼

@robertsLando robertsLando merged commit 57691cf into mqttjs:main Feb 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants