Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FXIOS-11279 - [Toolbar Redesign] Selecting any search suggestion doesn't open google with new tab with custom URL (backport #24611) #24631

Open
wants to merge 1 commit into
base: release/v135
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 7, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

  • To avoid a synchronization problem where the suggestion was tapped and instead of being searched for, the overlay mode would get canceled, not performing the search based on the tapped suggestion, this PR checks for the toolbar refactor if the search term is nil, meaning that the search is not tapped nor highlighted, so it's okay to leave overlay mode.

Video

video.MP4

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

This is an automatic backport of pull request #24611 done by [Mergify](https://mergify.com).

…on doesn't open google with new tab with custom URL (#24611)

* Check for nil of search term before exiting overlay mode

* Revert change

* Rename method

* Remove final

(cherry picked from commit aa856cf)
@mergify mergify bot requested a review from a team as a code owner February 7, 2025 12:10
@mergify mergify bot requested review from ih-codes and removed request for a team February 7, 2025 12:10
@PARAIPAN9 PARAIPAN9 requested review from PARAIPAN9 and removed request for ih-codes February 7, 2025 12:14
@rvandermeulen rvandermeulen added the weekly-release Tagging backports for rapid release label Feb 10, 2025
@rvandermeulen
Copy link
Contributor

Per Slack discussion with @afurlan-firefox, we'll target the 135.2 weekly release for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
weekly-release Tagging backports for rapid release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants