Skip to content

Commit

Permalink
Additional tests for expectedError.errorResponse
Browse files Browse the repository at this point in the history
Adds basic tests for expectedError.errorResponse under the unified test format, which are derived from the operation-failure tests in valid-fail.

Also adds tests for write operations (i.e. insert, update, delete, and bulkWrite), which may be problematic for some drivers that use special exceptions such as BulkWriteException, which may not provide direct access to a single response. Note that tests should avoid using errorResponse assertions for such operations and permit drivers to skip those tests as needed.
  • Loading branch information
jmikola committed Oct 11, 2022
1 parent 17eea3c commit 082b2e8
Show file tree
Hide file tree
Showing 11 changed files with 628 additions and 3 deletions.
87 changes: 87 additions & 0 deletions source/crud/tests/unified/bulkWrite-errorResponse.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
{
"description": "bulkWrite-errorResponse",
"schemaVersion": "1.12",
"createEntities": [
{
"client": {
"id": "client0"
}
},
{
"database": {
"id": "database0",
"client": "client0",
"databaseName": "crud-tests"
}
},
{
"collection": {
"id": "collection0",
"database": "database0",
"collectionName": "test"
}
}
],
"tests": [
{
"description": "bulkWrite operations support errorResponse assertions",
"runOnRequirements": [
{
"minServerVersion": "4.0.0",
"topologies": [
"single",
"replicaset"
]
},
{
"minServerVersion": "4.2.0",
"topologies": [
"sharded"
]
}
],
"operations": [
{
"name": "failPoint",
"object": "testRunner",
"arguments": {
"client": "client0",
"failPoint": {
"configureFailPoint": "failCommand",
"mode": {
"times": 1
},
"data": {
"failCommands": [
"insert"
],
"errorCode": 8
}
}
}
},
{
"name": "bulkWrite",
"object": "collection0",
"arguments": {
"requests": [
{
"insertOne": {
"document": {
"_id": 1
}
}
}
]
},
"expectError": {
"errorCode": 8,
"errorResponse": {
"code": 8
}
}
}
]
}
]
}
44 changes: 44 additions & 0 deletions source/crud/tests/unified/bulkWrite-errorResponse.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
description: "bulkWrite-errorResponse"

schemaVersion: "1.12"

createEntities:
- client:
id: &client0 client0
- database:
id: &database0 database0
client: *client0
databaseName: &database0Name crud-tests
- collection:
id: &collection0 collection0
database: *database0
collectionName: &collection0Name test

tests:
- description: "bulkWrite operations support errorResponse assertions"
runOnRequirements:
- minServerVersion: "4.0.0"
topologies: [ single, replicaset ]
- minServerVersion: "4.2.0"
topologies: [ sharded ]
operations:
- name: failPoint
object: testRunner
arguments:
client: *client0
failPoint:
configureFailPoint: failCommand
mode: { times: 1 }
data:
failCommands: [ insert ]
errorCode: &errorCode 8 # UnknownError
- name: bulkWrite
object: *collection0
arguments:
requests:
- insertOne:
document: { _id: 1 }
expectError:
errorCode: *errorCode
errorResponse:
code: *errorCode
81 changes: 81 additions & 0 deletions source/crud/tests/unified/deleteOne-errorResponse.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
{
"description": "deleteOne-errorResponse",
"schemaVersion": "1.12",
"createEntities": [
{
"client": {
"id": "client0"
}
},
{
"database": {
"id": "database0",
"client": "client0",
"databaseName": "crud-tests"
}
},
{
"collection": {
"id": "collection0",
"database": "database0",
"collectionName": "test"
}
}
],
"tests": [
{
"description": "delete operations support errorResponse assertions",
"runOnRequirements": [
{
"minServerVersion": "4.0.0",
"topologies": [
"single",
"replicaset"
]
},
{
"minServerVersion": "4.2.0",
"topologies": [
"sharded"
]
}
],
"operations": [
{
"name": "failPoint",
"object": "testRunner",
"arguments": {
"client": "client0",
"failPoint": {
"configureFailPoint": "failCommand",
"mode": {
"times": 1
},
"data": {
"failCommands": [
"delete"
],
"errorCode": 8
}
}
}
},
{
"name": "deleteOne",
"object": "collection0",
"arguments": {
"filter": {
"_id": 1
}
},
"expectError": {
"errorCode": 8,
"errorResponse": {
"code": 8
}
}
}
]
}
]
}
42 changes: 42 additions & 0 deletions source/crud/tests/unified/deleteOne-errorResponse.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
description: "deleteOne-errorResponse"

schemaVersion: "1.12"

createEntities:
- client:
id: &client0 client0
- database:
id: &database0 database0
client: *client0
databaseName: &database0Name crud-tests
- collection:
id: &collection0 collection0
database: *database0
collectionName: &collection0Name test

tests:
- description: "delete operations support errorResponse assertions"
runOnRequirements:
- minServerVersion: "4.0.0"
topologies: [ single, replicaset ]
- minServerVersion: "4.2.0"
topologies: [ sharded ]
operations:
- name: failPoint
object: testRunner
arguments:
client: *client0
failPoint:
configureFailPoint: failCommand
mode: { times: 1 }
data:
failCommands: [ delete ]
errorCode: &errorCode 8 # UnknownError
- name: deleteOne
object: *collection0
arguments:
filter: { _id: 1 }
expectError:
errorCode: *errorCode
errorResponse:
code: *errorCode
81 changes: 81 additions & 0 deletions source/crud/tests/unified/insertOne-errorResponse.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
{
"description": "insertOne-errorResponse",
"schemaVersion": "1.12",
"createEntities": [
{
"client": {
"id": "client0"
}
},
{
"database": {
"id": "database0",
"client": "client0",
"databaseName": "crud-tests"
}
},
{
"collection": {
"id": "collection0",
"database": "database0",
"collectionName": "test"
}
}
],
"tests": [
{
"description": "insert operations support errorResponse assertions",
"runOnRequirements": [
{
"minServerVersion": "4.0.0",
"topologies": [
"single",
"replicaset"
]
},
{
"minServerVersion": "4.2.0",
"topologies": [
"sharded"
]
}
],
"operations": [
{
"name": "failPoint",
"object": "testRunner",
"arguments": {
"client": "client0",
"failPoint": {
"configureFailPoint": "failCommand",
"mode": {
"times": 1
},
"data": {
"failCommands": [
"insert"
],
"errorCode": 8
}
}
}
},
{
"name": "insertOne",
"object": "collection0",
"arguments": {
"document": {
"_id": 1
}
},
"expectError": {
"errorCode": 8,
"errorResponse": {
"code": 8
}
}
}
]
}
]
}
42 changes: 42 additions & 0 deletions source/crud/tests/unified/insertOne-errorResponse.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
description: "insertOne-errorResponse"

schemaVersion: "1.12"

createEntities:
- client:
id: &client0 client0
- database:
id: &database0 database0
client: *client0
databaseName: &database0Name crud-tests
- collection:
id: &collection0 collection0
database: *database0
collectionName: &collection0Name test

tests:
- description: "insert operations support errorResponse assertions"
runOnRequirements:
- minServerVersion: "4.0.0"
topologies: [ single, replicaset ]
- minServerVersion: "4.2.0"
topologies: [ sharded ]
operations:
- name: failPoint
object: testRunner
arguments:
client: *client0
failPoint:
configureFailPoint: failCommand
mode: { times: 1 }
data:
failCommands: [ insert ]
errorCode: &errorCode 8 # UnknownError
- name: insertOne
object: *collection0
arguments:
document: { _id: 1 }
expectError:
errorCode: *errorCode
errorResponse:
code: *errorCode
Loading

0 comments on commit 082b2e8

Please sign in to comment.