feat: remove top-level write concern options #2630
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code changes include: the
WriteConcern
type now has only one property:writeConcern: WriteConcern | WriteConcernSettings
, whereWriteConcernSettings
(naming up for debate) encompasses the old top-level options.WriteConcern.fromOptions
ignores the old top-level WC options.The change to
legalOptionNames
indb.ts
means the old top-level WC options will be filtered out when creating aDb
. The change tovalidOptionNames
inoperations/connect.ts
means it will either error or warn (configurable) if the old top-level WC options are passed to aMongoClient
.Test changes include everything from #2624 and now all options that are not being used to create a connection string use the
writeConcern
key.