Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add explain support for non-cursor commands #2599
feat: add explain support for non-cursor commands #2599
Changes from 14 commits
a8dfabe
5bded70
4374b6b
f00fbfe
1d937a8
2a9b1be
237a70f
c2d0a53
0126381
82715bd
3bf0d78
7090c39
82f0e60
f5e65ed
4bdf503
03333d7
20ef5da
c1a4ff9
2c7334b
d486214
ddc9826
6a17656
7235fb7
001ec2e
0b37761
31bb9eb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we overload
explainSupported
to handle either anop: string
or acmd: Document
, instead of having two separate methods that are pretty similar in implementation?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a stylistic nit, but I think it'd be better to do
cmd.explain ? decorateWithExplain(cmd, cmd.explain) : cmd
here rather than reassigning thecmd
parameter.