added more tests to comply w kickoff - no docker tests still

mongodb · Feb 29, 2024 · ee781fc · ee781fc
1 parent 7fcb95e
commit ee781fc
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/src/cmap/connect.ts b/src/cmap/connect.ts
@@ -201,6 +201,7 @@ export async function prepareHandshakeDocument(
   const compressors = options.compressors ? options.compressors : [];
   const { serverApi } = authContext.connection;
   const clientMetadata = await addContainerMetadata(options.metadata);
+
   const handshakeDoc: HandshakeDocument = {
     [serverApi?.version || options.loadBalanced === true ? 'hello' : LEGACY_HELLO_COMMAND]: 1,
     helloOk: true,

diff --git a/test/unit/cmap/connect.test.ts b/test/unit/cmap/connect.test.ts
@@ -205,6 +205,23 @@ describe('Connect Tests', async function () {
           const handshakeDocument = await prepareHandshakeDocument(authContext);
           expect(handshakeDocument.client.env.container.orchestrator).to.equal('kubernetes');
         });
+
+        it(`should not have 'name' property in client.env `, async () => {
+          const handshakeDocument = await prepareHandshakeDocument(authContext);
+          expect(handshakeDocument.client.env).to.not.have.property('name');
+        });
+      });
+    });
+
+    context('when container nor FAAS env is not present', async () => {
+      const authContext = {
+        connection: {},
+        options: { ...CONNECT_DEFAULTS }
+      };
+
+      it(`should not have 'env' property in client`, async () => {
+        const handshakeDocument = await prepareHandshakeDocument(authContext);
+        expect(handshakeDocument.client).to.not.have.property('env');
       });
     });