-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore! update mongodb to v6 #1289
Conversation
4818ee4
to
c5f84b2
Compare
@daniel-sc please can you update the test "should convert BinData to string" that you wrote in #1254 to support bson v6 (string format is removed from Binary)? |
@rtritto how would you like that - I probably have no write access to this branch? Probably the change would be straight forward: old: const test = { bin: new bson.Binary('test', 80) }; new: const test = { bin: new bson.Binary(new TextEncoder().encode('test'), 80) }; |
Thanks, I did the commit. |
79faaa1
to
e1ca7b3
Compare
e1ca7b3
to
fb1771c
Compare
a325a07
to
f314ac3
Compare
This change is
Utilities
TODO
bson
to v6mongodb-query-parser
version to a compatible bson v6 one (v4?) --> https://github.com/mongodb-js/query-parser/issues/138mongodb-query-parser
v4.0.0 is patched in rtritto/query-parser#4.0.0-fix-bindatassl
-->tls
(it can be reverted)sslValidate
-->tlsAllowInvalidCertificates
sslCA
-->tlsCAFile
ME_CONFIG_MONGODB_SSL
-->ME_CONFIG_MONGODB_TLS
(it can be reverted)ME_CONFIG_MONGODB_SSLVALIDATE
-->ME_CONFIG_MONGODB_TLS_ALLOW_CERTS
ME_CONFIG_MONGODB_CA_FILE
-->ME_CONFIG_MONGODB_TLS_CA_FILE
ME_CONFIG_MONGODB_TLS_CERT_FILE
ME_CONFIG_MONGODB_TLS_CERT_KEY_FILE
ME_CONFIG_MONGODB_TLS_CERT_KEY_FILE_PASSWORD
db.command
(used by/lib/routes/collection.js
) isn't removed (source)should convert BinData to string
--> source: feat(NODE-4769)!: remove ISO-8859-1 string support from Binary mongodb/js-bson#602 --> need helpClose: #1203