Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore! update mongodb to v6 #1289

Merged
merged 7 commits into from
Dec 7, 2023
Merged

chore! update mongodb to v6 #1289

merged 7 commits into from
Dec 7, 2023

Conversation

rtritto
Copy link
Member

@rtritto rtritto commented Aug 31, 2023

This change is Reviewable


Utilities

TODO

Close: #1203

@rtritto rtritto added dependencies Pull requests that update a dependency file help wanted labels Aug 31, 2023
@rtritto rtritto force-pushed the update-mongodb-v6 branch from 4818ee4 to c5f84b2 Compare October 6, 2023 07:53
@rtritto
Copy link
Member Author

rtritto commented Oct 15, 2023

@daniel-sc please can you update the test "should convert BinData to string" that you wrote in #1254 to support bson v6 (string format is removed from Binary)?
Maybe changes in test of mongodb/js-bson#602 can help.

@daniel-sc
Copy link
Contributor

@daniel-sc please can you update the test "should convert BinData to string" that you wrote in #1254 to support bson v6 (string format is removed from Binary)? Maybe changes in test of mongodb/js-bson#602 can help.

@rtritto how would you like that - I probably have no write access to this branch?

Probably the change would be straight forward:

old:

const test = { bin: new bson.Binary('test', 80) };

new:

const test = { bin: new bson.Binary(new TextEncoder().encode('test'), 80) };

@rtritto
Copy link
Member Author

rtritto commented Oct 16, 2023

Thanks, I did the commit.

@rtritto rtritto marked this pull request as ready for review November 18, 2023 13:34
@rtritto
Copy link
Member Author

rtritto commented Nov 18, 2023

FYI @shakaran @BlackthornYugen

@rtritto rtritto force-pushed the update-mongodb-v6 branch 2 times, most recently from a325a07 to f314ac3 Compare November 18, 2023 14:17
@shakaran shakaran merged commit de63b8c into master Dec 7, 2023
4 checks passed
@shakaran shakaran deleted the update-mongodb-v6 branch December 7, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file draft upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants