test(csi-1130): api and db lib tests

package.json

@@ -119,7 +119,7 @@
     "@mojaloop/event-sdk": "14.1.3",
     "@mojaloop/inter-scheme-proxy-cache-lib": "2.3.1",
     "@mojaloop/ml-number": "11.2.6",
-    "@mojaloop/ml-schema-transformer-lib": "^2.5.1",
+    "@mojaloop/ml-schema-transformer-lib": "^2.5.2",
     "@mojaloop/sdk-standard-components": "^19.6.4",
     "ajv": "8.17.1",
     "ajv-keywords": "5.1.0",

src/data/database.js

@@ -49,11 +49,12 @@ const LOCAL_ENUM = require('../lib/enum')
  * Abstracts operations against the database
  */
 class Database {
-  constructor (config, log) {
+  constructor (config, log, queryBuilder) {
     this.config = config
     this.log = log || logger.child({
       context: this.constructor.name
     })
+    this.queryBuilder = queryBuilder
   }
 
   /**
@@ -62,7 +63,7 @@ class Database {
      * @returns {promise}
      */
   async connect () {
-    this.queryBuilder = new Knex(this.config.database)
+    this.queryBuilder = this.queryBuilder || new Knex(this.config.database)
 
     return this
   }
@@ -72,14 +73,14 @@ class Database {
   }
 
   /**
-     * async utility for getting a transaction object from knex
-     *
-     * @returns {undefined}
-     */
+   * async utility for getting a transaction object from knex
+   *
+   * @returns {undefined}
+   */
   async newTransaction () {
     return new Promise((resolve, reject) => {
       try {
-        this.queryBuilder.transaction(txn => {
+        return this.queryBuilder.transaction(txn => {
           return resolve(txn)
         })
       } catch (err) {

test/unit/api/quotes.test.js

@@ -120,4 +120,18 @@ describe('POST /quotes API Tests -->', () => {
     expect(spyErrorLog).toHaveBeenCalledTimes(1)
     expect(spyErrorLog.mock.calls[0][0]).toContain(error.message)
   })
+
+  it('should rethrow errors if metrics are disabled', async () => {
+    // Arrange
+    const error = new Error('Create Quote Test Error')
+    Producer.produceMessage = jest.fn(async () => { throw error })
+
+    const mockRequest = mocks.mockHttpRequest()
+    const { handler } = mocks.createMockHapiHandler()
+    mockRequest.server.app.config.instrumentationMetricsDisabled = true
+
+    // Act / Assert
+    await expect(() => quotesApi.post(mockContext, mockRequest, handler))
+      .rejects.toThrowError(error.message)
+  })
 })

test/unit/api/quotes/{id}.test.js

@@ -122,6 +122,19 @@ describe('/quotes/{id} API Tests -->', () => {
       expect(spyErrorLog).toHaveBeenCalledTimes(1)
       expect(spyErrorLog.mock.calls[0][0]).toContain(error.message)
     })
+
+    it('should rethrow error if mertics is diabled', async () => {
+      // Arrange
+      const error = new Error('Get Quote Test Error')
+      Producer.produceMessage = jest.fn(async () => { throw error })
+      const mockRequest = mocks.mockHttpRequest()
+      const { handler } = mocks.createMockHapiHandler()
+      mockRequest.server.app.config.instrumentationMetricsDisabled = true
+
+      // Act
+      await expect(() => quotesApi.get(mockContext, mockRequest, handler))
+        .rejects.toThrowError(error.message)
+    })
   })
 
   describe('PUT /quotes/{id} Endpoint Tests', () => {
@@ -197,6 +210,19 @@ describe('/quotes/{id} API Tests -->', () => {
       expect(spyErrorLog).toHaveBeenCalledTimes(1)
       expect(spyErrorLog.mock.calls[0][0]).toContain(error.message)
     })
+
+    it('should rethrow error if mertics is diabled', async () => {
+      // Arrange
+      const error = new Error('Put Quote Test Error')
+      Producer.produceMessage = jest.fn(async () => { throw error })
+      const mockRequest = mocks.mockHttpRequest()
+      const { handler } = mocks.createMockHapiHandler()
+      mockRequest.server.app.config.instrumentationMetricsDisabled = true
+
+      // Act
+      await expect(() => quotesApi.put(mockContext, mockRequest, handler))
+        .rejects.toThrowError(error.message)
+    })
   })
 
   describe('PUT /quotes/{id}/error API Tests -->', () => {

test/unit/data/database.test.js

@@ -48,8 +48,6 @@ Logger.isDebugEnabled = jest.fn(() => true)
 Logger.isErrorEnabled = jest.fn(() => true)
 Logger.isInfoEnabled = jest.fn(() => true)
 
-let database
-
 /**
  * @function mockKnexBuilder
  * @description Stubs out a set of Knex calls in order
@@ -85,6 +83,8 @@ describe('/database', () => {
     raw: jest.fn()
   }
 
+  let database
+
   describe('raw queries', () => {
     const config = {}
 
@@ -103,18 +103,38 @@ describe('/database', () => {
       expect(database.queryBuilder).not.toBeUndefined()
     })
 
-    // describe('initializes a transaction', () => {
-    //   it('returns a transaction in a promise', async () => {
-    //     // Arrange
-    //     mockKnex.transaction.mockReturnValueOnce('testTx')
+    describe('transaction', () => {
+      it('should resolve with a transaction', async () => {
+        const mockTransaction = {}
+        const queryBuilder = { transaction: jest.fn() }
+        queryBuilder.transaction.mockImplementation((callback) => {
+          callback(mockTransaction)
+        })
+        const database = new Database(config, Logger, queryBuilder)
+
+        const result = await database.newTransaction()
 
-    //     // Act
-    //     const result = await database.newTransaction()
+        expect(result).toBe(mockTransaction)
+        expect(queryBuilder.transaction).toHaveBeenCalled()
+      })
 
-    //     // Assert
-    //     expect(result).toBe('testTx')
-    //   })
-    // })
+      it('should reject with an error', async () => {
+        const mockError = new Error('Transaction error')
+        const queryBuilder = { transaction: jest.fn() }
+        const mockTransaction = {}
+        queryBuilder.transaction.mockImplementation((callback) => {
+          callback(mockTransaction)
+        })
+        const database = new Database(config, Logger, queryBuilder)
+
+        queryBuilder.transaction.mockImplementation(() => {
+          throw mockError
+        })
+
+        await expect(database.newTransaction()).rejects.toThrow('Transaction error')
+        expect(queryBuilder.transaction).toHaveBeenCalled()
+      })
+    })
 
     describe('isConnected', () => {
       it('returns true when connected', async () => {