Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mojaloop/#3759): fix incorrect error description #469

Merged
merged 6 commits into from
Mar 1, 2024
Merged

chore(mojaloop/#3759): fix incorrect error description #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
87e2591
chore: fix incorrect error description
kleyow Feb 27, 2024
aaace4f
chore(snapshot): 15.2.2-snapshot.0
kleyow Feb 27, 2024
fea1628
audit
kleyow Feb 27, 2024
6ef257a
chore(snapshot): 15.2.2-snapshot.1
kleyow Feb 27, 2024
194c0fd
fix logger issue
kleyow Feb 28, 2024
2d93657
chore(snapshot): 15.2.2-snapshot.2
kleyow Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .ncurc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## Add a TODO comment indicating the reason for each rejected dependency upgrade added to this list, and what should be done to resolve it (i.e. handle it through a story, etc).
reject: [
# TODO: v6+ (ref: https://github.com/sindresorhus/get-port/releases/tag/v6.0.0) is an ESM library and thus not compatible with CommonJS. Future story needed to resolve.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# TODO: v6+ (ref: https://github.com/sindresorhus/get-port/releases/tag/v6.0.0) is an ESM library and thus not compatible with CommonJS. Future story needed to resolve.
# NOTE: v6+ (ref: https://github.com/sindresorhus/get-port/releases/tag/v6.0.0) is an ESM library and thus not compatible with CommonJS. Future story needed to resolve.

"get-port"
"get-port",
"@mojaloop/sdk-standard-components",
]
136 changes: 92 additions & 44 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "account-lookup-service",
"description": "Account Lookup Service is used to validate Party and Participant lookups.",
"version": "15.2.1",
"version": "15.2.2-snapshot.2",
"license": "Apache-2.0",
"author": "ModusBox",
"contributors": [
Expand Down Expand Up @@ -79,7 +79,7 @@
"@hapi/boom": "10.0.1",
"@hapi/catbox-memory": "6.0.1",
"@hapi/good": "9.0.1",
"@hapi/hapi": "21.3.2",
"@hapi/hapi": "21.3.3",
"@hapi/inert": "7.1.0",
"@hapi/joi": "17.1.1",
"@hapi/vision": "7.0.3",
Expand All @@ -95,10 +95,10 @@
"ajv": "8.12.0",
"ajv-keywords": "5.1.0",
"blipp": "4.0.2",
"commander": "11.1.0",
"commander": "12.0.0",
"fast-safe-stringify": "^2.1.1",
"hapi-auth-bearer-token": "8.0.0",
"joi": "17.11.0",
"joi": "17.12.2",
"knex": "3.1.0",
"mustache": "4.2.0",
"mysql": "2.18.1",
Expand All @@ -108,17 +108,17 @@
"uuid4": "2.0.3"
},
"devDependencies": {
"@types/jest": "29.5.11",
"@types/jest": "29.5.12",
"audit-ci": "^6.6.1",
"axios": "1.6.2",
"axios": "1.6.7",
"docdash": "2.0.2",
"get-port": "5.1.1",
"jest": "29.7.0",
"jest-junit": "16.0.0",
"jsdoc": "4.0.2",
"nodemon": "3.0.2",
"nodemon": "3.1.0",
"npm-audit-resolver": "3.0.0-RC.0",
"npm-check-updates": "16.14.12",
"npm-check-updates": "16.14.15",
"nyc": "15.1.0",
"pre-commit": "1.2.2",
"proxyquire": "2.1.3",
Expand Down
4 changes: 2 additions & 2 deletions src/domain/parties/parties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ const getPartiesByTypeAndID = async (headers, params, method, query, span = unde
}

if (filteredResponsePartyList == null || !(Array.isArray(filteredResponsePartyList) && filteredResponsePartyList.length > 0)) {
Logger.isErrorEnabled && Logger.error('Requester FSP not found')
throw ErrorHandler.Factory.createFSPIOPError(ErrorHandler.Enums.FSPIOPErrorCodes.ID_NOT_FOUND, 'Requester FSP not found')
Logger.isErrorEnabled && Logger.error('Requested FSP/Party not found')
throw ErrorHandler.Factory.createFSPIOPError(ErrorHandler.Enums.FSPIOPErrorCodes.ID_NOT_FOUND, 'Requested FSP/Party not found')
}

for (const party of filteredResponsePartyList) {
Expand Down
Loading