Compatibility deserialization of DiscreteTrajectory2 #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggrobin
approved these changes
Oct 22, 2021
physics/discrete_trajectory2.hpp
Outdated
| @@ -117,6 +120,9 @@ class DiscreteTrajectory2 : public Trajectory<Frame> { | |||
| typename Segments::iterator FindSegment(Instant const& t); | |||
| typename Segments::const_iterator FindSegment(Instant const& t) const; | |||
|
|
|||
| //TODO(phl): comment. | |||
There was a problem hiding this comment.
comment?
Also, Is suggests a boolean, IsConsistent().ok() is weird. If we have a status, maybe it should be called Consistency.
There was a problem hiding this comment.
Changed to ValidateConsistency.
There was a problem hiding this comment.
A verb phrase in the infinitive suggests void to me, so that I might write ValidateConsistency(); and expect that to, well, validate the consistency.
A noun phrase seems better for a status.
| EXPECT_THAT(log_warning.string(), | ||
| AllOf(HasSubstr("pre-Ζήνων"), Not(HasSubstr("pre-Haar")))); | ||
|
|
||
| // Note that the sizes don't have the same semantics as pre-Haar. The |
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also extracted
StringLogSinkand removed const-ness from some APIs (to make it possible to set the downsampling of a segment).#3136.