control: forward traces in a non-blocking goroutine #5912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the trace forwarder in the controller to process the traces in another goroutine to prevent the original client from blocking when the downstream exporter isn't available. If buildkit was configured to export traces, it would proxy the traces from a client. This export was blocking and caused the upstream client to stall until buildkit had successfully sent the trace to its external collector. This changes the forwarding to be non-blocking from the client's perspective. Signed-off-by: Jonathan A. Sternberg <[email protected]>
jsternberg
force-pushed
the
trace-forwarder-buildx-stall
branch
from
601dcdc to
ff4cde9
Compare
fiam
reviewed
Apr 17, 2025
|
|
||
| func NewExporter(exp sdktrace.SpanExporter) *Exporter { | ||
| return &Exporter{ | ||
| bsp: sdktrace.NewBatchSpanProcessor(exp), |
There was a problem hiding this comment.
question: This seems to drop spans if the processor's queue becomes full. Should we initialize it to block instead in that scenario?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the trace forwarder in the controller to process the traces in
another goroutine to prevent the original client from blocking when the
downstream exporter isn't available.
If buildkit was configured to export traces, it would proxy the traces
from a client. This export was blocking and caused the upstream client
to stall until buildkit had successfully sent the trace to its external
collector.
This changes the forwarding to be non-blocking from the client's
perspective.
Fixes #4616.