-
Notifications
You must be signed in to change notification settings - Fork 1.2k
wip: wcow: option to run builds in hyperv isolation #5753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Add an option to run builds in hyper-v isolation mode for Windows images. WIP Checklist: - [x] Test with basic image runs - [ ] Test with bind and cache mounts - [ ] Test with CNI capability (this will not work, needs documentation) - [ ] Discuss which flags to use to expose this, `--isolated` like in `ctr`? Fixes moby#5682 Signed-off-by: Anthony Nandaa <[email protected]>
Looks like this boiled down to adding a flag, nice. I can't generate binaries on my dev machine to test this (happy to try it if you supply some or have a friendlier Windows dev workflow). Agree with your suggestion that we add a |
@riverar -- you can get the binaries from the test-os/build stage "Upload Artifacts" here - https://github.com/moby/buildkit/actions/runs/13385668839/artifacts/2607353633 |
@profnandaa No issues so far, works as expected. |
Is there a reason why, unlike containerd and moby, isolation is specified via env variable instead of a command-line Also, how this will interoperate with |
I think it was the fastest way to prove out the concept in this draft PR and not indicative of any final design. |
yes, that's right, this was just a POC. |
Add an option to run builds in hyper-v isolation mode for Windows images.
WIP Checklist:
--isolated
like inctr
?Fixes #5682
Basic Test
When the build is at the RUN stage, on a different terminal, try to run:
Now try to build the same image with
ENV BUILDKIT_HYPERV_ISOLATED=0
or without the env variable,should get something like: