Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datatypes.py #316

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Update datatypes.py #316

merged 1 commit into from
Mar 8, 2022

Conversation

HugoJP1
Copy link
Contributor

@HugoJP1 HugoJP1 commented Mar 4, 2022

Hi - I was attempting to use GetVariableResultType, and realised that there is a typo in the definition of variable.

@HugoJP1 HugoJP1 requested review from OrangeTux and tropxy as code owners March 4, 2022 17:15
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@OrangeTux OrangeTux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for fixing.

@OrangeTux OrangeTux merged commit 14059e9 into mobilityhouse:master Mar 8, 2022
@HugoJP1 HugoJP1 deleted the patch-1 branch March 8, 2022 10:46
@OSkrk
Copy link
Collaborator

OSkrk commented Mar 11, 2022

Hello @OrangeTux - How do you generate the datatypes.py file from the json schemas?

@OrangeTux
Copy link
Contributor

We created a few scripts that generate this code based on the JSON schema. You can find them in https://github.com/mobilityhouse/ocpp/tree/master/scripts . Note that the output is not without errors and require manual fix up.

@OSkrk
Copy link
Collaborator

OSkrk commented Mar 11, 2022

Thank you for your answer @OrangeTux, I have tested the scripts and succesfully generated call, call_result and enums, but the file datatypes.py is not generated by these scripts. Is there a missing script?

@OrangeTux
Copy link
Contributor

I'm afraid we did that manually...

ajmirsky pushed a commit to ajmirsky/ocpp that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants