Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove depreciated get_schema code #249

Merged
merged 4 commits into from
Sep 16, 2021

Conversation

proelke
Copy link
Collaborator

@proelke proelke commented Sep 15, 2021

When running tests I noticed the following warning: UserWarning: Depricated as of 0.8.1. Please use ocpp.messages.get_validator()`

As the next revision will be 0.8.4, I figured I would submit a PR to remove this warning.

@proelke proelke requested a review from OrangeTux as a code owner September 15, 2021 00:49
@@ -168,14 +140,6 @@ def test_validate_get_composite_profile_payload():
validate_payload(message, ocpp_version="1.6")


def test_get_schema_with_invalid_name():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a test_get_validator_with_invalid_name ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope but there is now.

Copy link
Contributor

@OrangeTux OrangeTux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@OrangeTux OrangeTux merged commit 8d1968a into mobilityhouse:master Sep 16, 2021
ajmirsky pushed a commit to ajmirsky/ocpp that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants