-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UI layouts #950
Fix UI layouts #950
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
@freedomtan to check who is the MLCommons one who is responsible for this (adding a member to a repo, and find the CLA link). |
This comment was marked as resolved.
This comment was marked as resolved.
@farook-edev The screenshots I uploaded are just examples of the UI issue. I think there are more screens with similar issue. Could you please go through the UI of the app and fix all similar issue in this PR. |
…to-resizing text to progress circle
8331ce3
to
d8c77a4
Compare
@anhappdev I tested the screens on a 1x3 aspect ratio device and a 3 inch screen, the only problem i noticed is sometimes the download bar in the resource screen overflows, I'll fix that. I should also mention that this PR fixes a different issue that I noticed on the start screen, image attached: |
closing in favor of #955 |
This PR fixes #942 by making sure the app does not clip or overlap elements on extreme screen sizes.
The primary culprit behind the clipping was the many Expanded elements, those were simplified and only the variable size items (such as lists) were allowed to expand.