Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate string size in a browser precisely. #83

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

miktam
Copy link
Owner

@miktam miktam commented Feb 7, 2023

Fixes #82

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2023

Codecov Report

Merging #83 (4d7efa5) into master (d2dcd1d) will increase coverage by 1.47%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   95.74%   97.22%   +1.47%     
==========================================
  Files           2        2              
  Lines          47       72      +25     
==========================================
+ Hits           45       70      +25     
  Misses          2        2              
Impacted Files Coverage Δ
byte_size.js 100.00% <ø> (ø)
indexv2.js 97.18% <100.00%> (+1.53%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…string.

Tested on node v12 - works. Does not work on node v10.
Continuation of #82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Size difference between node and browser
2 participants