Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pathlib Paths in Loadable #2100

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

friggog
Copy link
Contributor

@friggog friggog commented Dec 20, 2023

@mikedh mikedh changed the base branch from main to release/removegeom December 23, 2023 00:31
@mikedh mikedh merged commit 9ed2aa0 into mikedh:release/removegeom Dec 23, 2023
9 checks passed
@mikedh
Copy link
Owner

mikedh commented Dec 23, 2023

Thanks for the fix! Just to double check it shouldn't have raised a runtime TypeError in this case, it's just that pylance/etc gets mad at it?

# pre this fix
In [4]: import trimesh

In [5]: from pathlib import Path

In [6]: trimesh.load(Path('models/featuretype.STL'))
Out[6]: <trimesh.Trimesh(vertices.shape=(1722, 3), faces.shape=(3476, 3), name=`featuretype.STL`)>


@friggog friggog deleted the fix/loadable branch December 23, 2023 08:28
@friggog
Copy link
Contributor Author

friggog commented Dec 23, 2023

Yeah exactly, not runtime error, but pylance and linters like Mypy would complain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants