Resolve regression in WSL launch script #72779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks @xtydev ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of today the WSL launch script is not working properly with the Insiders build — the empty
cli.js(as described in #13138) has re-emerged. The commit history of the file shows the problem was previously fixed by @Tyriar (9c298b0) and @0xabu (8505dcc). Upon further investigation, I came to the conclusion that the regression was introduced by b7ec5e8. Although I have no idea how the upcomingms-vscode.remote-wslextension will come in to play, it is still worth mentioning that right now L13-L25 serves no real purpose. To resolve the issue, I've (re)introduced various checks so as to launch VS Code from the WSL differently as per its build number.