Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gz-*] Rename gz-* ports #43945

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

talregev
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Mengna-Li Mengna-Li added the category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. label Feb 21, 2025
@dg0yt
Copy link
Contributor

dg0yt commented Feb 21, 2025

In the past, we had

  • smooth transitions when we upgraded the old names to empty ports which depend on the new name before eventually removing them (example: proj4 -> proj) and
  • users stumbling when we immediately removed the old name when add the new name (example: szip -> libaec, cf. [libaec] Build error on x64-windows #43846 et al.).

Just saying.

@talregev
Copy link
Contributor Author

In the past, we had

  • smooth transitions when we upgraded the old names to empty ports which depend on the new name before eventually removing them (example: proj4 -> proj) and
  • users stumbling when we immediately removed the old name when add the new name (example: szip -> libaec, cf. [libaec] Build error on x64-windows #43846 et al.).

Just saying.

Thank you for the info. That good practice.
Before I do that, I want to see if I can rename the ports in the first place.
There is an issue when they look for port, because it still looking in port name and number, but no longer available. (only port name).
Do you an idea how to solve that?

@talregev
Copy link
Contributor Author

talregev commented Feb 21, 2025

Thank you for the info. That good practice. Before I do that, I want to see if I can rename the ports in the first place. There is an issue when they look for port, because it still looking in port name and number, but no longer available. (only port name). Do you an idea how to solve that?

@traversaro Can you help too?

@dg0yt
Copy link
Contributor

dg0yt commented Feb 21, 2025

Before I do that, I want to see if I can rename the ports in the first place.

You can do that. CI won't complain because it starts from scratch. But classic mode users start with the old ports installed.

There is an issue when they look for port, because it still looking in port name and number, but no longer available. (only port name).

No 100% clear what you mean. But the proposed smooth approach would keep <name><number> in addition to <name>.

@traversaro
Copy link
Contributor

Thank you for the info. That good practice. Before I do that, I want to see if I can rename the ports in the first place. There is an issue when they look for port, because it still looking in port name and number, but no longer available. (only port name). Do you an idea how to solve that?

@traversaro Can you help too?

I am not sure I get what you meant with " There is an issue when they look for port, because it still looking in port name and number, but no longer available. (only port name)."

@talregev
Copy link
Contributor Author

talregev commented Feb 21, 2025

Sorry I didn't been clear.
From @traversaro comment:
#43265 (comment)

Gazebo packages installing with the package name with the major version. Since I rename the ports as @traversaro suggested:

I think it make perfect sense to drop all the version number suffixes and just package the latest major version of each gz library.

Clearly I didn't do the correct changes, and ci is fail due that it not find the package name with the major version.
My question how to make this refactor in a smooth approach?

@talregev talregev force-pushed the TalR/gz_ports_rename branch 6 times, most recently from c114a30 to 5642692 Compare February 21, 2025 11:13
@talregev talregev force-pushed the TalR/gz_ports_rename branch from 5642692 to 7d9526b Compare February 22, 2025 08:15
@talregev
Copy link
Contributor Author

I figure it out.

@talregev
Copy link
Contributor Author

I bring back old ports as @dg0yt suggested:

smooth transitions when we upgraded the old names to empty ports which depend on the new name before eventually removing them

@talregev talregev marked this pull request as ready for review February 22, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants